Merged
Conversation
Contributor
Author
|
/CC @nodejs/testing |
Contributor
Author
|
Another reason I like this change is it adds an explicit P.S. I'm aware of the lint. Looking for some buy-in before I do a second pass. |
jasnell
approved these changes
Aug 27, 2018
Member
|
(signed off to +1 the idea, looks like there are a few nits to fix tho) |
addaleax
approved these changes
Aug 27, 2018
Member
There was a problem hiding this comment.
nit: We typically spell out code here
Contributor
Author
There was a problem hiding this comment.
Ack.
(also the actual, and expected args were swapped)
refack
force-pushed
the
refacotr-out-spawnPwd
branch
from
4103318 to
b35a046
Compare
Contributor
Author
* extract the gist into common.pwdCommand * Merge test-child-process-buffering.js into test-child-process-stdio.js PR-URL: nodejs#22522 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
refack
force-pushed
the
refacotr-out-spawnPwd
branch
from
b35a046 to
8569f4a
Compare
Contributor
Author
|
landed in 8569f4a |
targos
pushed a commit
that referenced
this pull request
Aug 30, 2018
* extract the gist into common.pwdCommand * Merge test-child-process-buffering.js into test-child-process-stdio.js PR-URL: #22522 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
* extract the gist into common.pwdCommand * Merge test-child-process-buffering.js into test-child-process-stdio.js PR-URL: #22522 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
* extract the gist into common.pwdCommand * Merge test-child-process-buffering.js into test-child-process-stdio.js PR-URL: #22522 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further work on
common/index.js.common.pwdCommandtest-child-process-buffering.jsintotest-child-process-stdio.jsChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes