test: improve code coverage for string decoder#22306
test: improve code coverage for string decoder#22306BeniCheni wants to merge 2 commits intonodejs:masterfrom BeniCheni:string-decoder-test-coverage
Conversation
trivikr
added
the
author ready
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16452/ ✔️ |
|
Hi, collaborators, (cc @trivikr @Trott who helped to post CI instances in previous comments) Saw some approvals & read the previous failed CI instance w. the referred issue above. I have rebased the feature branch of this PR and pushed, as an attempt to obtain a "green" CI instance. After the attempt, the current PR seems to have a "green" CI instance. Would you mind guiding this PR to "land", after the "green" CI instance has been obtained & approvals? |
|
Landed in 5673017 🎉 @BeniCheni Thanks! Usually a simple ping is enough to get things done.
By the way, it looks like you used something that creates a “merge commit” (which is what you get by default from running |
PR-URL: #22306 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Thank you for landing! Good to learn about the rebase workflow, which I'd be mindful about. |
PR-URL: #22306 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #22306 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #22306 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
9 participants
This PR attempts to cover this line of uncovered string decoder code from the coverage report, after exploring with nodejs/getting-started repo that led to consulting with nodetodo.org about contributing to unit test code.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes