test: add support for NODE_TEST_DIR on a separate mount point#21552
test: add support for NODE_TEST_DIR on a separate mount point#21552aduh95 wants to merge 1 commit intonodejs:masterfrom
Conversation
Linux permits a filesystem to be mounted at multiple points, but `fs.renameSync` does not work across different mount points, even if the same filesystem is mounted on both. This fixes failing tests when NODE_TEST_DIR mount point is different from the one on which the tests are executed (E.G. on a separate partition). Ref: http://man7.org/linux/man-pages/man2/rename.2.html
|
@nodejs/testing |
|
this seems reasonable to me, @cjihrig did you have similar reasoning around the |
Yes, specifically the |
|
Has my PR anything to do with intl or is it just a random CI fail? Is there something I can do to fix this fail? |
|
@nodejs/fs |
Probably unrelated to this. Re-running CI now since it's been a while anyway. |
Linux permits a filesystem to be mounted at multiple points, but `fs.renameSync` does not work across different mount points, even if the same filesystem is mounted on both. This fixes failing tests when NODE_TEST_DIR mount point is different from the one on which the tests are executed (E.G. on a separate partition). Ref: http://man7.org/linux/man-pages/man2/rename.2.html PR-URL: nodejs#21552 Refs: http://man7.org/linux/man-pages/man2/rename.2.html Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Coe <bencoe@gmail.com>
|
Landed in b75bde3 |
Linux permits a filesystem to be mounted at multiple points, but `fs.renameSync` does not work across different mount points, even if the same filesystem is mounted on both. This fixes failing tests when NODE_TEST_DIR mount point is different from the one on which the tests are executed (E.G. on a separate partition). Ref: http://man7.org/linux/man-pages/man2/rename.2.html PR-URL: #21552 Refs: http://man7.org/linux/man-pages/man2/rename.2.html Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Coe <bencoe@gmail.com>
8 participants
Linux permits a filesystem to be mounted at multiple points, but
fs.renameSyncdoes not work across different mount points, even if the same filesystem is mounted on both.This fixes failing tests when NODE_TEST_DIR mount point is different from the one on which the tests are executed (E.G. on a separate partition).
On my configuration, I have the node source on a NTFS partition (dual-boot Windows), and I want to avoid the tests on the
chmodto fail (the chmod is partition-wide and set when mounting). This PR allows to run the tests using a different tmpdir without having to move the node source to the same mount point.Ref: http://man7.org/linux/man-pages/man2/rename.2.html
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes