test: add promise API test for appendFile()#20739
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: add promise API test for appendFile()#20739Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Apply the first of five test cases in test-fs-append-file to the promise-based API in addition to the callback-based API.
Member
Author
jasnell
approved these changes
May 15, 2018
3 tasks
Trott
added
the
author ready
cjihrig
approved these changes
May 15, 2018
Member
Author
|
Landed in 0d9500d |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 17, 2018
Apply the first of five test cases in test-fs-append-file to the promise-based API in addition to the callback-based API. PR-URL: nodejs#20739 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
Apply the first of five test cases in test-fs-append-file to the promise-based API in addition to the callback-based API. PR-URL: #20739 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the first of five test cases in test-fs-append-file to the
promise-based API in addition to the callback-based API.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes