Update console.table docs.

[sant123]

Checklist

• documentation is changed or added

[Trott]

/ping @BridgeAR

[Trott]

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/600/

[Trott]

Commit message doesn't conform to the guidelines/conventions used, but especially for such a focused change, whoever is landing the code can certainly fix it.

In case that person is not me and whoever it is doesn't want to think about it, here's a suggested commit log:

doc: fix example in console.md

Update example code in console.md to be the correct code for generating the
output indicated.

[Trott]

Leave a 👍 here if you are a Collaborator in favor of fast-tracking this.

[vsemozhetbyt]

Should an example of a call without properties be added?

[vsemozhetbyt]

Also not sure if this is a typo: ...and logit. and if it can be addressed here on landing, feel free to ignore)

[vsemozhetbyt]

LGTM with ignorable nits in comments)

[Trott]

Should an example of a call without properties be added?

@vsemozhetbyt Yes (although it doesn't have to be in this pull request if @sant123 just wants to get a quick correction in and not spend time perfecting the console.table() example code beyond fixing a clear mistake). If you'd like, maybe push a second commit to this branch yourself adding that example?

[vsemozhetbyt]

@Trott If I push my own commit, will not this mess up with First-time contributor to Contributor promotion?

[Trott]

@Trott If I push my own commit, will not this mess up with First-time contributor to Contributor promotion?

If I had to guess, I wouldn't think so, but if you believe it might, you very well could be right!

[trivikr]

The parameter properties is optional here.
The output is same even if ['a', 'b'] is not passed as properties

[vsemozhetbyt]

For me:

> console.table([{ a: 1, b: 'Y' }, { a: 'Z', b: 2 }]);
┌─────────┬──────────────────┐
│ (index) │      Values      │
├─────────┼──────────────────┤
│    0    │ { a: 1, b: 'Y' } │
│    1    │ { a: 'Z', b: 2 } │
└─────────┴──────────────────┘

[vsemozhetbyt]

They are optional, but not with the same output it seems.

[trivikr]

@vsemozhetbyt You're right. I just verified it with Node.js v10.0.0
My bad, earlier I'd verified it on Google Chrome v66 where the output was same even if ['a', 'b'] is not passed as properties

[vsemozhetbyt]

I've pushed under the OP username and email, this can be reverted if I am wrong.

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/601/

[devsnek]

we should fix the bug not document the bugged behaviour

[Trott]

we should fix the bug not document the bugged behaviour

@devsnek OK. #20323

I'd like to leave this PR open until that one lands.

[Tiriel]

As noted in #17128 (comment) the method still appears in the inspector-only methods (line 508 on the new diff). Maybe we should take the opportunity to fix this?

[Trott]

As noted in #17128 (comment) the method still appears in the inspector-only methods (line 508 on the new diff). Maybe we should take the opportunity to fix this?

@Tiriel #20346

[Trott]

99d56a4 landed so this can be closed.

Thanks for spotting the error @sant123 and for submitting a pull request for it!