Skip to content

doc: create list for commonly edited files in PRs #19776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trivikr wants to merge 2 commits into from
Closed

doc: create list for commonly edited files in PRs #19776

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a84d79
doc: create list for commonly edited files in PRs
trivikr Apr 3, 2018
fafc5af
fixup: addressing comments from @addaleax
trivikr Apr 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions doc/guides/contributing/pull-requests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,11 @@ $ git checkout -b my-branch -t upstream/master
### Step 3: Code

The vast majority of Pull Requests opened against the `nodejs/node`
repository includes changes to either the C/C++ code contained in the `src`
directory, the JavaScript code contained in the `lib` directory, the
documentation in `docs/api` or tests within the `test` directory.
repository includes changes to one or more of the following:
- the C/C++ code contained in the `src` directory
- the JavaScript code contained in the `lib` directory
- the documentation in `docs/api`
Copy link
Copy Markdown
Member

@addaleax addaleax Apr 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Pre-existing) Typo: docs → doc :)

Copy link
Copy Markdown
Member Author

@trivikr trivikr Apr 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

- tests within the `test` directory.

If you are modifying code, please be sure to run `make lint` from time to
time to ensure that the changes follow the Node.js code style guide.
Expand Down