test: move ESM fixtures to fixtures dir#19409
Closed
targos wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
targos
added
the
esm
jasnell
approved these changes
Mar 17, 2018
guybedford
approved these changes
Mar 17, 2018
Contributor
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
Nice, thanks for cleaning these up!
richardlau
reviewed
Mar 17, 2018
cjihrig
approved these changes
Mar 19, 2018
devsnek
approved these changes
Mar 19, 2018
XadillaX
approved these changes
Mar 19, 2018
Also consistently import the `common` module where possible.
targos
force-pushed
the
test-esm-fixtures
branch
from
8a599b3 to
ecc6965
Compare
Member
Author
richardlau
approved these changes
Mar 21, 2018
Member
Author
|
Landed in fddcd62 |
targos
added a commit
that referenced
this pull request
Mar 21, 2018
Also consistently import the `common` module where possible. PR-URL: #19409 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also consistently import the
commonmodule where possible.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes