doc: fix minor grammar/typographical issues in onboarding.md#18847
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
doc: fix minor grammar/typographical issues in onboarding.md#18847Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
richardlau
reviewed
Feb 18, 2018
| including accommodation, transportation, visa fees etc. if needed. Check out | ||
| Node.js project, where we have face-to-face discussions about our work on the | ||
| project. The Foundation has travel funds to cover participants' expenses | ||
| including accommodations, transportation, visa fees, etc. if needed. Check out |
Member
There was a problem hiding this comment.
Is accommodations US English? Genuine question -- it looks odd to me but I am British.
Member
Author
There was a problem hiding this comment.
@richardlau I did not realize that was a peculiarity of US English, but yes, apparently it is. I've never seen it without the s at the end. Checked online in a few (non-authoritative but reliable enough) sources and it is indeed a US English tendency to add the s no matter what while the rest of the world doesn't do that.
Perhaps we can change it to lodging and it won't seem odd to anyone? :-D
Member
There was a problem hiding this comment.
I'm fine with keeping it as the docs should be written in American English. Only now I'm staring at transportation and wondering if that should end in s 😆.
richardlau
approved these changes
Feb 18, 2018
lpinca
approved these changes
Feb 18, 2018
BridgeAR
added
the
author ready
jasnell
approved these changes
Feb 18, 2018
JungMinu
approved these changes
Feb 19, 2018
maclover7
approved these changes
Feb 19, 2018
cjihrig
approved these changes
Feb 19, 2018
mmarchini
approved these changes
Feb 20, 2018
Member
Author
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 21, 2018
PR-URL: nodejs#18847 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Member
Author
|
Landed in e53275d |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18847 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18847 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18847 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18847 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc