Conversation
|
@yosuke-furukawa note you are going in as your gmail address even though your git email has changed, which do you prefer (see .mailmap diff on this PR)? |
|
@rvagg Can you include my actual name as well? Maybe like |
|
@thefourtheye we don't really have a convention of including github handles here, it's mainly just a list of names @ email addresses that are pulled from your git config (i.e. the git log). Would you mind if I made it just |
|
Sam Mikes smikes@cubane.com Thanks! On Fri, May 22, 2015 at 7:22 PM, Rod Vagg notifications@github.com
|
|
the entries now come up as See the .mailmap attached to this PR for what was done to make that happen. Will wait for feedback from @thefourtheye before proceeding. |
@raff Cool, that should be fine 😊 I ll update my |
|
LGTM |
|
@rvagg My email is yosuke.furukawa@gmail.com . |
Update AUTHORS list using tools/update-authors.sh PR-URL: nodejs#1776 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
367ffd1 |
Update AUTHORS list using tools/update-authors.sh PR-URL: nodejs/node#1776 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Update AUTHORS list using tools/update-authors.sh
@smikes and @thefourtheye you are going in as:
Can I put in a proper name for either of you or is this preferred?