[v6.x] deps: backport 4af8029 from upstream V8#17290
Closed
targos wants to merge 1 commit intonodejs:v6.x-stagingfrom
Closed
[v6.x] deps: backport 4af8029 from upstream V8#17290targos wants to merge 1 commit intonodejs:v6.x-stagingfrom
targos wants to merge 1 commit intonodejs:v6.x-stagingfrom
Conversation
nodejs-github-bot
added
v6.x
v8 engine
fhinkel
approved these changes
Nov 24, 2017
targos
commented
Nov 24, 2017
Member
Author
There was a problem hiding this comment.
I removed a slash by mistake. Will fix.
Contributor
|
@targos should we try and get this into v6.12.1 or can it wait a month? |
Original commit message:
[turbofan] Fix missing lazy deopt in object literals.
This adds a missing lazy bailout point when defining data properties
with computed property names in object literals. The runtime call to
Runtime::kDefineDataPropertyInLiteral can trigger deopts. The necessary
bailout ID already exists and is now properly used.
R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-621816
BUG=chromium:621816
Review-Url: https://codereview.chromium.org/2099133003
Cr-Commit-Position: refs/heads/master@{nodejs#37294}
Refs: v8/v8@4af8029
Fixes: nodejs#14326
Member
Author
|
I suppose it can wait if you are not comfortable releasing it right now. |
bnoordhuis
approved these changes
Nov 26, 2017
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
Nice job tracking down the fix for that bug, Michaël!
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
Original commit message:
[turbofan] Fix missing lazy deopt in object literals.
This adds a missing lazy bailout point when defining data properties
with computed property names in object literals. The runtime call to
Runtime::kDefineDataPropertyInLiteral can trigger deopts. The necessary
bailout ID already exists and is now properly used.
R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-621816
BUG=chromium:621816
Review-Url: https://codereview.chromium.org/2099133003
Cr-Commit-Position: refs/heads/master@{#37294}
Refs: v8/v8@4af8029
PR-URL: #17290
Fixes: #14326
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Contributor
|
landed in fa922b9 |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
Original commit message:
[turbofan] Fix missing lazy deopt in object literals.
This adds a missing lazy bailout point when defining data properties
with computed property names in object literals. The runtime call to
Runtime::kDefineDataPropertyInLiteral can trigger deopts. The necessary
bailout ID already exists and is now properly used.
R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-621816
BUG=chromium:621816
Review-Url: https://codereview.chromium.org/2099133003
Cr-Commit-Position: refs/heads/master@{#37294}
Refs: v8/v8@4af8029
PR-URL: #17290
Fixes: #14326
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@4af8029
Fixes: #14326
/cc @nodejs/v8
CI: https://ci.nodejs.org/job/node-test-pull-request/11696/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/1077/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
V8