[v4.x backport] Use external headers in addons tests#16550
Closed
gibfahn wants to merge 1 commit intonodejs:v4.x-stagingfrom
Closed
[v4.x backport] Use external headers in addons tests#16550gibfahn wants to merge 1 commit intonodejs:v4.x-stagingfrom
gibfahn wants to merge 1 commit intonodejs:v4.x-stagingfrom
Conversation
nodejs-github-bot
added
addons
Member
Author
|
Just backporting one commit (3c85f4e) from #6734, and #7947. Using internal headers like @MylesBorins Given that the rc is already out, if you don't want to pick this up then I understand. This cherry-picked cleanly (except for files that don't exist on 4.x). |
gibfahn
force-pushed
the
ext-headers-v4.x
branch
from
a9f67ad to
34d2d1e
Compare
Member
Author
Member
|
@gibfahn Can you also update |
Member
Author
Member
Author
bnoordhuis
approved these changes
Oct 28, 2017
MylesBorins
pushed a commit
that referenced
this pull request
Nov 2, 2017
Backport-PR-URL: #16550 PR-URL: #7947 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
|
landed in cb92f93 |
Member
Author
|
@MylesBorins I think you only landed one of the two commits here, could you include @bnoordhuis 's commit as well? I'll rebase on v4.x-staging. |
There is no real need and it causes endless grief on Windows with some of the upcoming changes. PR-URL: nodejs#6734 Backport-PR-URL: nodejs#16550 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gibfahn
force-pushed
the
ext-headers-v4.x
branch
from
4616dd8 to
b520c67
Compare
Member
Author
|
Rebased and removed the commit that already landed, @MylesBorins PTAL. |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
There is no real need and it causes endless grief on Windows with some of the upcoming changes. PR-URL: #6734 Backport-PR-URL: #16550 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Contributor
|
aw shucks, second commit landed in b19c123 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 7, 2017
There is no real need and it causes endless grief on Windows with some of the upcoming changes. PR-URL: #6734 Backport-PR-URL: #16550 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 8, 2017
There is no real need and it causes endless grief on Windows with some of the upcoming changes. PR-URL: #6734 Backport-PR-URL: #16550 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2018
There is no real need and it causes endless grief on Windows with some of the upcoming changes. PR-URL: #6734 Backport-PR-URL: #16550 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2018
There is no real need and it causes endless grief on Windows with some of the upcoming changes. PR-URL: #6734 Backport-PR-URL: #16550 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test/addons