test: add results to assertion messages#16024
Closed
kkwoker wants to merge 1 commit intonodejs:masterfrom
kkwoker:master
Closed
test: add results to assertion messages#16024kkwoker wants to merge 1 commit intonodejs:masterfrom kkwoker:master
kkwoker wants to merge 1 commit intonodejs:masterfrom
kkwoker:master
Conversation
joyeecheung
approved these changes
Oct 6, 2017
Member
Contributor
Author
|
I duplicated this PR in #16037, and have a better solution for cleaning up the assertion values |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit also puts the first two tests in scope.
expected_resultwas being overwritten in the second test before the first test passes, creating a race condition.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)