test: update test failure output to include exit code and signal#15945
Closed
jennazee wants to merge 2 commits intonodejs:masterfrom
Closed
test: update test failure output to include exit code and signal#15945jennazee wants to merge 2 commits intonodejs:masterfrom
jennazee wants to merge 2 commits intonodejs:masterfrom
Conversation
Trott
added
the
code-and-learn
BridgeAR
reviewed
Oct 7, 2017
Member
There was a problem hiding this comment.
The line length exceeds 80 characters here. This has to be fixed but it can also be done while landing.
jasnell
approved these changes
Oct 10, 2017
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM but will definitely need line wrapping to pass linting.
jennazee
force-pushed
the
test-cluster-server-messages
branch
from
d0d8c60 to
4fd69e2
Compare
gireeshpunathil
approved these changes
Oct 16, 2017
jasnell
reviewed
Oct 16, 2017
| assert.strictEqual(code, 0, `worker2 did not exit normally. exited with\ | ||
| code ${code}`); | ||
| assert.strictEqual(signal, null, `worker2 did not exit normally. exited\ | ||
| with signal ${signal}`); |
Member
There was a problem hiding this comment.
The basic change is good but we try to avoid using multi-line template literals in core. This can be improved by...
assert.strictEqual(code, 0,
'worker2 did not exit normally.' +
`exited with code ${code}`);
assert.strictEqual(signal, null,
'worker2 did not exit normally. ' +
`exited with signal ${signal}`);
Member
There was a problem hiding this comment.
That can be fixed on landing tho :-)
jasnell
pushed a commit
that referenced
this pull request
Oct 16, 2017
PR-URL: #15945 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com
Member
|
Landed in da7d92e. |
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #15945 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 18, 2017
PR-URL: nodejs/node#15945 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
PR-URL: #15945 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15945 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15945 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)