test: improve assert message in test-dh-regr#15912
Closed
Epitrochoid wants to merge 1 commit intonodejs:masterfrom
Closed
test: improve assert message in test-dh-regr#15912Epitrochoid wants to merge 1 commit intonodejs:masterfrom
Epitrochoid wants to merge 1 commit intonodejs:masterfrom
Conversation
Trott
added
the
code-and-learn
Member
BridgeAR
reviewed
Oct 9, 2017
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
This actually changes the test somewhat since it is not clear from the test if the same code path are still hit or not. That is probably the case but I would still prefer not to use base64 when calling computeSecret. The return value is a buffer and that could be changed to base64 when printing, instead of changing the arguments.
Trott
dismissed
their stale review
Agree with @BridgeAR that it would be preferable to not change the test, and that base64 can happen inside the template literal. Not a blocking objection for me, though.
Epitrochoid
force-pushed
the
update-assert-messages
branch
2 times, most recently
from
015035c to
2249287
Compare
Author
Member
|
This looks good, but it results in a lint error. (Run 'Secrets should be equal.\n' +
`aSecret: ${aSecret.toString('base64')}\n` +
`bSecret: ${bSecret.toString('base64')}` |
Epitrochoid
force-pushed
the
update-assert-messages
branch
from
2249287 to
97dfdb3
Compare
Author
|
Good catch, thanks. Fixed the long line, but I wasn't sure if it would be better to have |
Trott
approved these changes
Oct 12, 2017
Member
lpinca
approved these changes
Oct 13, 2017
jasnell
approved these changes
Oct 13, 2017
jasnell
pushed a commit
that referenced
this pull request
Oct 13, 2017
PR-URL: #15912 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 42dfde8. Thank you! |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
PR-URL: nodejs/node#15912 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #15912 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
PR-URL: #15912 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15912 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15912 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Node Interactive Code and Learn.
My task suggested improving the assert message in test-dh-regr as it currently doesn't print the failing values. To make the output readable I specified 'base64' as the encoding and print the secrets on test failure.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test