test: use fixtures module over fixturesDir#15847
Closed
JamesNimlos wants to merge 1 commit intonodejs:masterfrom
Closed
test: use fixtures module over fixturesDir#15847JamesNimlos wants to merge 1 commit intonodejs:masterfrom
JamesNimlos wants to merge 1 commit intonodejs:masterfrom
Conversation
clean up code by using fixtures helper module instead of fixturesDir directly. Refs: https://github.com/nodejs/node/tree/master/test/common#fixtures-module
rmg
approved these changes
Oct 6, 2017
Contributor
rmg
left a comment
rmg
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the contribution!
Trott
added
the
code-and-learn
mscdex
added
the
cli
benjamingr
approved these changes
Oct 7, 2017
jasnell
approved these changes
Oct 10, 2017
gireeshpunathil
approved these changes
Oct 10, 2017
lpinca
approved these changes
Oct 11, 2017
Member
|
spurious crash in smart-os. Re-CI: https://ci.nodejs.org/job/node-test-pull-request/10665/ |
Member
|
CI is showing green, but no tests were actually run. Something is not working on CI. Will have to run again after it's fixed. |
Member
Member
|
New limited CI on arm: https://ci.nodejs.org/job/node-test-binary-arm/10882/ |
Member
|
Landed in 4e835b3, thanks for the contribution! |
joyeecheung
pushed a commit
that referenced
this pull request
Oct 14, 2017
clean up code by using fixtures helper module instead of fixturesDir directly. PR-URL: #15847 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Contributor
Author
|
Awesome, thanks everyone!! 🤩 |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
clean up code by using fixtures helper module instead of fixturesDir directly. PR-URL: nodejs/node#15847 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
clean up code by using fixtures helper module instead of fixturesDir directly. PR-URL: #15847 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
clean up code by using fixtures helper module instead of fixturesDir directly. PR-URL: #15847 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
clean up code by using fixtures helper module instead of fixturesDir directly. PR-URL: #15847 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
clean up code by using fixtures helper module instead of fixturesDir directly. PR-URL: #15847 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clean up code by using fixtures helper module
instead of fixturesDir directly.
Refs: https://github.com/nodejs/node/tree/master/test/common#fixtures-module
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
N/A