Skip to content

doc: rephrase wording of child_process.execSync() #14953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ayazhafiz wants to merge 2 commits into from
Closed

doc: rephrase wording of child_process.execSync() #14953

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
416ea4f
doc: rephrase wording of child_process.execSync()
ayazhafiz Aug 20, 2017
ebf0b49
doc: add child_process prefix to spawnSync
ayazhafiz Aug 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/api/child_process.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,8 +685,8 @@ does not exit, the parent process will still wait until the child process has
exited.

If the process times out, or has a non-zero exit code, this method ***will***
throw. The [`Error`][] object will contain the entire result from
[`child_process.spawnSync()`][]
throw an [`Error`][] that will include the full result of the underlying
[`spawnSync()`][].
Copy link
Copy Markdown
Member

@lpinca lpinca Aug 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the child_process. prefix for consistency.

Copy link
Copy Markdown
Contributor

@daxlab daxlab Aug 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

considering this nit, rest all LGTM.

Copy link
Copy Markdown
Contributor Author

@ayazhafiz ayazhafiz Aug 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, should be fixed now!


### child_process.execSync(command[, options])
<!-- YAML
Expand Down Expand Up @@ -1339,6 +1339,7 @@ unavailable.
[`process.on('disconnect')`]: process.html#process_event_disconnect
[`process.on('message')`]: process.html#process_event_message
[`process.send()`]: process.html#process_process_send_message_sendhandle_options_callback
[`spawnSync()`]: #child_process_child_process_spawnsync_command_args_options
[`stdio`]: #child_process_options_stdio
[`util.promisify()`]: util.html#util_util_promisify_original
[Default Windows Shell]: #child_process_default_windows_shell
Expand Down