repl: remove NODE_REPL_HISTORY_FILE

[BridgeAR]

This is a alternative to #13733
The history file was only active in io.js 2.x and was deprecated in io.js 3.0. I think it's safe to remove this instead of fixing the error handling but I thought having both here to decide on is the best to do.

I'll finish the tests if it's decided that it should be removed instead of fixed.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

repl

[cjihrig]

Maybe we should create an official end of life deprecation entry before removing. @jasnell WDYT?

[jasnell]

Yep, I agree. Let's mark it end of life in docs/api/deprecations.md in 9.0 and look to remove in 10.0.

[BridgeAR]

@cjihrig @jasnell is this really necessary in this case? The old format would immediately be migrated to the new format by starting the repl. So it's a one time process for each user that specifically used io.js 2 and it was already deprecated in io.js 3. It is a history file so would anyone want to rely on a history file that would be two years old?

[refack]

@cjihrig @jasnell is this really necessary in this case? The old format would immediately be migrated to the new format by starting the repl. So it's a one time process for each user that specifically used io.js 2 and it was already deprecated in io.js 3. It is a history file so would anyone want to rely on a history file that would be two years old?

Since it's a low-risk/low-reward situation, I believe going by the book is just safer... So we'll need to mark it EOL in the docs.

[jasnell]

Agree. Let's mark it EOL in 9.x

[BridgeAR]

I rebased this and even though the run-time deprecation did not yet land, I personally feel like it is absolutely fine to directly go to the end-of-life as this does not hurt anyone even in the very unlikely case that someone still uses io.js 2.x and directly updates to 10.x.

[BridgeAR]

CI https://ci.nodejs.org/job/node-test-pull-request/13084/

[mcollina]

LGTM

[BridgeAR]

Landed in 60c9ad7.