errors: add missing ERR_ prefix on util.callbackify error by jasnell · Pull Request #13604 · nodejs/node

jasnell · 2017-06-11T03:35:50Z

The FALSY_VALUE_REJECTION error code added by #12712 did not have the ERR_ prefix, nor was it added to the errors.md documentation. Add the prefix in for consistency.

#12712 is a semver-minor but it has not yet been shipped in a release. If it had been shipped, then this PR would have had to been semver-major. This should land in a release the same time as af3aa68

/cc @refack @addaleax

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

util, errors

The `FALSY_VALUE_REJECTION` error code added by nodejs#12712 did not have the `ERR_` prefix, nor was it added to the errors.md documentation. Add the prefix in for consistency.

addaleax

Thanks for noticing, I think it’s okay to fast-track this (edit: to be clear, fast-track to be sure they get in the same release, not because I’d include it in #13598)

addaleax · 2017-06-11T10:45:33Z

CI: https://ci.nodejs.org/job/node-test-commit/10500/

refack · 2017-06-11T11:00:31Z

Just for my information, why is this important?
(particularly in this case where the Error is not exactly an error?)

jasnell · 2017-06-11T13:06:55Z

@refack ... Largely for sake of consistency.

jasnell · 2017-06-11T13:08:54Z

Failures in CI are concerning but are not related to this change

refack · 2017-06-11T14:35:53Z

arm failure: #13603
aix failure: #13577

Rerun (just in case)
arm-fanned: https://ci.nodejs.org/job/node-test-commit-arm-fanned/9350/

The `FALSY_VALUE_REJECTION` error code added by #12712 did not have the `ERR_` prefix, nor was it added to the errors.md documentation. Add the prefix in for consistency. PR-URL: #13604 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

jasnell · 2017-06-13T19:36:14Z

Landed in 873e2f2

The `FALSY_VALUE_REJECTION` error code added by nodejs#12712 did not have the `ERR_` prefix, nor was it added to the errors.md documentation. Add the prefix in for consistency. PR-URL: nodejs#13604 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

The `FALSY_VALUE_REJECTION` error code added by #12712 did not have the `ERR_` prefix, nor was it added to the errors.md documentation. Add the prefix in for consistency. Original-PR-URL: #13604 Original-Reviewed-By: Luigi Pinca <[email protected]> Original-Reviewed-By: Timothy Gu <[email protected]> Original-Reviewed-By: Gibson Fahnestock <[email protected]> Original-Reviewed-By: Anna Henningsen <[email protected]> Original-Reviewed-By: Refael Ackermann <[email protected]> Original-Reviewed-By: Colin Ihrig <[email protected]> Original-Reviewed-By: Benjamin Gruenbaum <[email protected]> PR-URL: #13750 Reviewed-By: Anna Henningsen <[email protected]>

Refs: nodejs#13604 Refs: nodejs#13627

The `FALSY_VALUE_REJECTION` error code added by #12712 did not have the `ERR_` prefix, nor was it added to the errors.md documentation. Add the prefix in for consistency. Original-PR-URL: #13604 Original-Reviewed-By: Luigi Pinca <[email protected]> Original-Reviewed-By: Timothy Gu <[email protected]> Original-Reviewed-By: Gibson Fahnestock <[email protected]> Original-Reviewed-By: Anna Henningsen <[email protected]> Original-Reviewed-By: Refael Ackermann <[email protected]> Original-Reviewed-By: Colin Ihrig <[email protected]> Original-Reviewed-By: Benjamin Gruenbaum <[email protected]> PR-URL: #13750 Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #13869 Refs: #13604 Refs: #13627 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

The `FALSY_VALUE_REJECTION` error code added by #12712 did not have the `ERR_` prefix, nor was it added to the errors.md documentation. Add the prefix in for consistency. Original-PR-URL: #13604 Original-Reviewed-By: Luigi Pinca <[email protected]> Original-Reviewed-By: Timothy Gu <[email protected]> Original-Reviewed-By: Gibson Fahnestock <[email protected]> Original-Reviewed-By: Anna Henningsen <[email protected]> Original-Reviewed-By: Refael Ackermann <[email protected]> Original-Reviewed-By: Colin Ihrig <[email protected]> Original-Reviewed-By: Benjamin Gruenbaum <[email protected]> PR-URL: #13750 Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #13869 Refs: #13604 Refs: #13627 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

The `FALSY_VALUE_REJECTION` error code added by #12712 did not have the `ERR_` prefix, nor was it added to the errors.md documentation. Add the prefix in for consistency. Original-PR-URL: #13604 Original-Reviewed-By: Luigi Pinca <[email protected]> Original-Reviewed-By: Timothy Gu <[email protected]> Original-Reviewed-By: Gibson Fahnestock <[email protected]> Original-Reviewed-By: Anna Henningsen <[email protected]> Original-Reviewed-By: Refael Ackermann <[email protected]> Original-Reviewed-By: Colin Ihrig <[email protected]> Original-Reviewed-By: Benjamin Gruenbaum <[email protected]> PR-URL: #13750 Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #13869 Refs: #13604 Refs: #13627 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

The `FALSY_VALUE_REJECTION` error code added by #12712 did not have the `ERR_` prefix, nor was it added to the errors.md documentation. Add the prefix in for consistency. Original-PR-URL: #13604 Original-Reviewed-By: Luigi Pinca <[email protected]> Original-Reviewed-By: Timothy Gu <[email protected]> Original-Reviewed-By: Gibson Fahnestock <[email protected]> Original-Reviewed-By: Anna Henningsen <[email protected]> Original-Reviewed-By: Refael Ackermann <[email protected]> Original-Reviewed-By: Colin Ihrig <[email protected]> Original-Reviewed-By: Benjamin Gruenbaum <[email protected]> PR-URL: #13750 Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #13869 Refs: #13604 Refs: #13627 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

errors: add missing ERR_ prefix on util.callbackify error

4ed4fa4

The `FALSY_VALUE_REJECTION` error code added by nodejs#12712 did not have the `ERR_` prefix, nor was it added to the errors.md documentation. Add the prefix in for consistency.

nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. util Issues and PRs related to the built-in util module. labels Jun 11, 2017

jasnell requested a review from refack June 11, 2017 03:36

lpinca approved these changes Jun 11, 2017

View reviewed changes

TimothyGu approved these changes Jun 11, 2017

View reviewed changes

gibfahn approved these changes Jun 11, 2017

View reviewed changes

addaleax approved these changes Jun 11, 2017

View reviewed changes

refack approved these changes Jun 11, 2017

View reviewed changes

cjihrig approved these changes Jun 11, 2017

View reviewed changes

benjamingr approved these changes Jun 11, 2017

View reviewed changes

jasnell closed this Jun 13, 2017

refack mentioned this pull request Jun 17, 2017

(v8.x backport) 12712 - util: add util.callbackify() #13750

Closed

4 tasks

refack added the backported-to-v8.x label Jun 17, 2017

tniessen added a commit to tniessen/node that referenced this pull request Jun 22, 2017

doc: unify ERR_FALSY_VALUE_REJECTION description

118fd32

Refs: nodejs#13604 Refs: nodejs#13627

tniessen mentioned this pull request Jun 22, 2017

doc: unify ERR_FALSY_VALUE_REJECTION description #13869

Closed

2 tasks

jasnell mentioned this pull request Oct 30, 2017

Proposal: 2017-10-31, Version 9.0.0 (Current) #15135

Merged

MylesBorins added the dont-land-on-v6.x label Nov 16, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

errors: add missing ERR_ prefix on util.callbackify error#13604

errors: add missing ERR_ prefix on util.callbackify error#13604
jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell:fixup-callbackify-error-code

jasnell commented Jun 11, 2017 •

edited

Loading

Uh oh!

addaleax left a comment •

edited

Loading

Uh oh!

addaleax commented Jun 11, 2017

Uh oh!

refack commented Jun 11, 2017

Uh oh!

jasnell commented Jun 11, 2017

Uh oh!

jasnell commented Jun 11, 2017

Uh oh!

refack commented Jun 11, 2017

Uh oh!

jasnell commented Jun 13, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

jasnell commented Jun 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Uh oh!

addaleax left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

addaleax commented Jun 11, 2017

Uh oh!

refack commented Jun 11, 2017

Uh oh!

jasnell commented Jun 11, 2017

Uh oh!

jasnell commented Jun 11, 2017

Uh oh!

refack commented Jun 11, 2017

Uh oh!

jasnell commented Jun 13, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

jasnell commented Jun 11, 2017 •

edited

Loading

addaleax left a comment •

edited

Loading