test: have inspector test pick an open port#10861
Merged
eugeneo merged 1 commit intonodejs:masterfrom Jan 19, 2017
eugeneo:concurrent-test
Merged
test: have inspector test pick an open port#10861eugeneo merged 1 commit intonodejs:masterfrom eugeneo:concurrent-test
eugeneo merged 1 commit intonodejs:masterfrom
eugeneo:concurrent-test
Conversation
nodejs-github-bot
added
c++
jasnell
approved these changes
Jan 18, 2017
cjihrig
approved these changes
Jan 19, 2017
src/inspector_socket_server.cc
Outdated
Contributor
There was a problem hiding this comment.
Would it make more sense to return the error code and pass the port through a function argument (basically the reverse of the current situation)?
Contributor
Author
|
@cjihrig I did that, new version uploaded. |
cjihrig
approved these changes
Jan 19, 2017
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
Thanks. LGTM if the CI comes back green.
Contributor
Author
|
For some reason, GitHub integration is showing failed tests while https://ci.nodejs.org/job/node-test-pull-request/5950/ is green. |
Contributor
|
Yea, that has been a problem for a while now. I think the build team has it on their radar. |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
This ensures that cctest can be ran concurrently with other instances of cctest or while the node is ran with --inspect. Ref: nodejs#10858 PR-URL: nodejs#10861 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
This ensures that cctest can be ran concurrently with other instances of cctest or while the node is ran with --inspect. Ref: nodejs#10858 PR-URL: nodejs#10861 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that cctest can be ran concurrently with other instances of
cctest or while the node is ran with --inspect.
Ref: #10858
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, inspector - server now works with the port 0 and test leverages that.