test: fix accidental skipping of pseudo-tty test#10191
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: fix accidental skipping of pseudo-tty test#10191Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
The empty file `test/pseudo-tty/stdin-setrawmode.out` was missing from the repository. This caused the test stdin-setrawmode.js to be skipped and a warning to be printed when running commands like: tools/test.py --mode=release -J pseudo-tty or: make test or: make test-ci
Trott
added
test
Member
Author
cjihrig
approved these changes
Dec 9, 2016
Member
|
CI failures are real, see #10149 for a proper fix (which I will attempt to land now if train wifi allows it) |
addaleax
added
duplicate
Member
|
Landed #10149 so this should no longer be necessary :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test tty
Description of change
The empty file
test/pseudo-tty/stdin-setrawmode.outwas missing fromthe repository. This caused the test stdin-setrawmode.js to be skipped
and a warning to be printed when running commands like:
tools/test.py --mode=release -J pseudo-tty
or:
make test
or:
make test-ci