Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
=======================================
Coverage 83.03% 83.03%
=======================================
Files 37 37
Lines 4178 4178
=======================================
Hits 3469 3469
Misses 709 709 ☔ View full report in Codecov by Sentry. |
Member
|
we should probably also publish one last version to https://www.npmjs.com/package/node-core-utils with a output/warning saying it moved |
Contributor
Author
I think we can |
Member
|
The current NPM_TOKEN should work. I can replace it with a granular one when the package exists on npm. |
MoLow
previously approved these changes
Jun 2, 2023
Member
|
release-please workflow needs an update as well. |
targos
approved these changes
Jun 12, 2023
MoLow
approved these changes
Jun 12, 2023
VoltrexKeyva
approved these changes
Jun 16, 2023
aduh95
force-pushed
the
scoped-package-name
branch
from
9e46a3b to
c5f695f
Compare
nodejs-github-bot
pushed a commit
to nodejs/node
that referenced
this pull request
Sep 25, 2023
Refs: https://github.com/nodejs/node-core-utils/releases/tag/v4.0.0 PR-URL: #49851 Refs: nodejs/node-core-utils#700 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno
pushed a commit
to nodejs/node
that referenced
this pull request
Sep 28, 2023
Refs: https://github.com/nodejs/node-core-utils/releases/tag/v4.0.0 PR-URL: #49851 Refs: nodejs/node-core-utils#700 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno
pushed a commit
to nodejs/node
that referenced
this pull request
Sep 28, 2023
Refs: https://github.com/nodejs/node-core-utils/releases/tag/v4.0.0 PR-URL: #49851 Refs: nodejs/node-core-utils#700 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
Refs: https://github.com/nodejs/node-core-utils/releases/tag/v4.0.0 PR-URL: nodejs#49851 Refs: nodejs/node-core-utils#700 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure this is ready yet, we may need a new NPM_TOKEN on the repo secret.
Refs: nodejs/TSC#1178