feat: check CI failures before land#422
Merged
codebytere merged 1 commit intonodejs:masterfrom May 26, 2020
Merged
Conversation
codebytere
force-pushed
the
pr-checker-jenkins-failures
branch
from
75a1028 to
0ca7fc2
Compare
codebytere
force-pushed
the
pr-checker-jenkins-failures
branch
from
0ca7fc2 to
b3796ec
Compare
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
==========================================
+ Coverage 76.34% 77.13% +0.79%
==========================================
Files 21 21
Lines 1484 1496 +12
==========================================
+ Hits 1133 1154 +21
+ Misses 351 342 -9
Continue to review full report at Codecov.
|
joyeecheung
approved these changes
May 26, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #377.
We were previously checking for actual CI results in GitHub Actions-based CI, but not for Jenkins - this adds in and updates logic to aggregate Jenkins results into landing preparation.
Using nodejs/node#33498 as a test case:
Before:
After:
cc @sam-github @joyeecheung @targos