git-node v8: remove eu-strip during major upgrades#243
Merged
joyeecheung merged 2 commits intonodejs:masterfrom May 3, 2018
Merged
git-node v8: remove eu-strip during major upgrades#243joyeecheung merged 2 commits intonodejs:masterfrom
joyeecheung merged 2 commits intonodejs:masterfrom
Conversation
Member
Author
|
Note: Node's gitignore was updated in nodejs/node#20304 to ignore the |
priyank-p
approved these changes
May 1, 2018
Contributor
priyank-p
left a comment
priyank-p
left a comment
There was a problem hiding this comment.
LGTM, after the lint issue is fixed.
lib/update-v8/util.js
Outdated
| const fs = require('fs-extra'); | ||
| const path = require('path'); | ||
|
|
||
| const constants = require('./constants'); |
Contributor
There was a problem hiding this comment.
This line needs be removed, the lint fails here since its not required anymore.
This comment has been minimized.
This comment has been minimized.
joyeecheung
approved these changes
May 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: nodejs/node#20304