tsfn: support direct calls to underlying napi_tsfn#580
Merged
mhdawson merged 5 commits intonodejs:masterfrom Nov 10, 2019
Merged
tsfn: support direct calls to underlying napi_tsfn#580mhdawson merged 5 commits intonodejs:masterfrom
mhdawson merged 5 commits intonodejs:masterfrom
Conversation
Contributor
Author
|
The implementation for this is based off previous napi meeting discussion, see #556 (comment) |
Member
|
Looks reasonable to me @gabrielschulhof can you take a look at as well? |
gabrielschulhof
approved these changes
Nov 5, 2019
doc/threadsafe_function.md
Outdated
|
|
||
| napi_status Napi::ThreadSafeFunction::NonBlockingCall(void* data) const | ||
| ``` | ||
| - `data`: Data to pass to `call_js_cb` specified when creating the tsfn via |
Contributor
There was a problem hiding this comment.
Suggested change
| - `data`: Data to pass to `call_js_cb` specified when creating the tsfn via | |
| - `data`: Data to pass to `call_js_cb` specified when creating the thread-safe function via |
Contributor
Author
There was a problem hiding this comment.
After a nasty fight between 500s from GitHub's commit suggestion API and various force pushes, this is comment has been updated 👍
db3482b to
74544ac
Compare
Contributor
Author
|
Hi @mhdawson / @gabrielschulhof dunno what to do for this build failure: https://travis-ci.com/nodejs/node-addon-api/jobs/253158482 |
Contributor
|
@KevinEady I restarted the job. |
Contributor
Author
|
Hi @mhdawson just a reminder on landing this |
legendecas
reviewed
Nov 7, 2019
legendecas
approved these changes
Nov 7, 2019
legendecas
approved these changes
Nov 7, 2019
Member
|
Landed as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #556