Split the object test into smaller tests (get/set/delete/hasOwnProperty)#183
Closed
romandev wants to merge 1 commit intonodejs:masterfrom
Closed
Split the object test into smaller tests (get/set/delete/hasOwnProperty)#183romandev wants to merge 1 commit intonodejs:masterfrom
romandev wants to merge 1 commit intonodejs:masterfrom
Conversation
Contributor
Author
|
@mhdawson PTAL |
mhdawson
approved these changes
Nov 8, 2017
Member
mhdawson
left a comment
There was a problem hiding this comment.
Overall LGTM. I'm on vacation for the next week so I'll look at landing when I get back or if another reviewer takes a look between now and then they can go head earlier.
Contributor
Author
|
@mhdawson Thank you for review and I'll request another reviewer. Have a good vacation :) |
Contributor
Author
|
@addaleax Could you please review this patch if you have a minute? |
Member
|
Ran the tests locally on linux and I got this failure: With this PR backed out the tests ran ok. @romandev can you take a look. You can run the tests with npm-test |
This change breaks the object test into smaller tests for the following
reasons:
- Smaller tests are better than very large one. (e.g. readability)
- Before this patch, we have missed some test cases. For example,
there are four overloading versions of the deleteProperty() method,
but we haven't tested them all until now.
Contributor
Author
|
@mhdawson Done. I've just fixed the error. Thank you! |
mhdawson
pushed a commit
that referenced
this pull request
Nov 17, 2017
Split the object test into smaller tests (get/set/delete/hasOwnProperty)
This change breaks the object test into smaller tests for the following
reasons:
- Smaller tests are better than very large one. (e.g. readability)
- Before this patch, we have missed some test cases. For example,
there are four overloading versions of the deleteProperty() method,
but we haven't tested them all until now.
PR-URL: #183
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Member
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Split the object test into smaller tests (get/set/delete/hasOwnProperty)
This change breaks the object test into smaller tests for the following
reasons:
- Smaller tests are better than very large one. (e.g. readability)
- Before this patch, we have missed some test cases. For example,
there are four overloading versions of the deleteProperty() method,
but we haven't tested them all until now.
PR-URL: nodejs/node-addon-api#183
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Split the object test into smaller tests (get/set/delete/hasOwnProperty)
This change breaks the object test into smaller tests for the following
reasons:
- Smaller tests are better than very large one. (e.g. readability)
- Before this patch, we have missed some test cases. For example,
there are four overloading versions of the deleteProperty() method,
but we haven't tested them all until now.
PR-URL: nodejs/node-addon-api#183
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Split the object test into smaller tests (get/set/delete/hasOwnProperty)
This change breaks the object test into smaller tests for the following
reasons:
- Smaller tests are better than very large one. (e.g. readability)
- Before this patch, we have missed some test cases. For example,
there are four overloading versions of the deleteProperty() method,
but we haven't tested them all until now.
PR-URL: nodejs/node-addon-api#183
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Split the object test into smaller tests (get/set/delete/hasOwnProperty)
This change breaks the object test into smaller tests for the following
reasons:
- Smaller tests are better than very large one. (e.g. readability)
- Before this patch, we have missed some test cases. For example,
there are four overloading versions of the deleteProperty() method,
but we haven't tested them all until now.
PR-URL: nodejs/node-addon-api#183
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change breaks the object test into smaller tests for the following
reasons:
there are four overloading versions of the deleteProperty() method,
but we haven't tested them all until now.