Add a new Int node to parse intBE, intLE, uIntBE and uIntLE values.#1
Draft
arthurschreiber wants to merge 2 commits intonodejs:masterfrom
Draft
Add a new Int node to parse intBE, intLE, uIntBE and uIntLE values.#1arthurschreiber wants to merge 2 commits intonodejs:masterfrom
Int node to parse intBE, intLE, uIntBE and uIntLE values.#1arthurschreiber wants to merge 2 commits intonodejs:masterfrom
Conversation
indutny
requested changes
Jan 6, 2020
Member
indutny
left a comment
indutny
left a comment
There was a problem hiding this comment.
Needs a tests, but otherwise looks pretty good!
src/node/int.ts
Outdated
| * @param field State's property name | ||
| */ | ||
| constructor(public readonly field: string, public readonly bytes: number, public readonly signed: boolean, public readonly littleEndian: boolean) { | ||
| super(field + '_' + (signed ? 'int' : 'uint') + '_' + (bytes * 8) + (bytes > 1 ? '_' + (littleEndian ? 'le' : 'be') : '')); |
Member
There was a problem hiding this comment.
Nitpick: let's move compound expressions to separate variables and use template syntax here.
Author
There was a problem hiding this comment.
That's a bit problematic - the super call needs to be the very first instruction in the constuctor. 😞I'll try to clean this up a but with the template syntax.
Author
There was a problem hiding this comment.
I extracted the name generation to a separate function to work around the super call requirement. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.