src: fix object inspection for V8 6.4#192
Merged
mmarchini merged 2 commits intonodejs:masterfrom May 15, 2018
Merged
Conversation
V8 6.4 "replaces the in-object properties count byte in the map with the byte that stores the start offset of in-object properties". Object inspection on llnode relies on in-object properties being count bytes, so these are minimal changes to make object inspection work again with V8 6.4 while keeping compatibility with previous versions. Ref: https://chromium-review.googlesource.com/c/v8/v8/+/776720 Fixes: nodejs#158
Contributor
Author
There are 5 calls to |
Contributor
Author
|
Improved legibility on InObjectProperty and handled the case where Map don't describe a JSObject. @bnoordhuis PTAL. Would be nice to have a test for this case. I'll see if I can come up with one later, but suggestions are appreciated 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V8 6.4 "replaces the in-object properties count byte in the map
with the byte that stores the start offset of in-object properties".
Object inspection on llnode relies on in-object properties being count
bytes, so these are minimal changes to make object inspection work again
with V8 6.4 while keeping compatibility with previous versions.
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/776720
Fixes: #158