test: more consistent test for findjsobjects -d#188
Merged
joyeecheung merged 1 commit intonodejs:masterfrom May 2, 2018
Merged
test: more consistent test for findjsobjects -d#188joyeecheung merged 1 commit intonodejs:masterfrom
joyeecheung merged 1 commit intonodejs:masterfrom
Conversation
findjsobjects -d test relies on how the hidden-class it tests is built. Zlib is a builtin from Node.js, therefore we cannot be sure about the order attributes are assigned to the class, making its hidden-class unpredictable. Using a class from our fixtures (in this case, Class) makes the test more predictable across Node.js versions and across multiple Operating Systems. Ref: nodejs#186
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findjsobjects -d test relies on how the hidden-class it tests is built.
Zlib is a builtin from Node.js, therefore we cannot be sure about the
order attributes are assigned to the class, making its hidden-class
unpredictable. Using a class from our fixtures (in this case, Class)
makes the test more predictable across Node.js versions and across
multiple Operating Systems.
Ref: #186