Conversation
lib/pollTravis.js
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
e34cfd3 to
4363a1c
Compare
|
Fixes: #14 |
7be5ef6 to
dd117b5
Compare
|
rebased |
|
LGTM |
|
You mentioned on IRC that we should be polling SHA for all repos. Any reason you haven't deleted IIRC this means we would do status updates for readable-stream, but still do comments on nodejs.org and citgm. |
|
Have you tested updates on PRs and how that affects previously set statuses? Could we end up with misleading success status on a PR if the first build succeeded, but new commits/pushed rebase results in brokens builds? |
|
@phillipj I left that because I wasn't sure if it was still necessary. Afaik statuses tie to commits, so if the commits are updated GitHub automatically resets it. |
|
I'll give it a test when I get home later though. |
lib/pollTravis.js
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
dd117b5 to
10cf185
Compare
|
Hmmm, looks like this no-longer works after being rebased on #8. Investigating. |
|
Got it working. My bad. Looks like this doesn't actually handle PR updates, working on it. (Example: TestOrgPleaseIgnore/test-github-bot#17) |
10cf185 to
8bb7182
Compare
|
Updated, now works for PR updates: TestOrgPleaseIgnore/test-github-bot#17 |
8bb7182 to
1c11bb3
Compare
|
going to open a new PR for some of the other bits |
Discussion in nodejs#15
Here's a test of a success status, and a failure status.
cc @williamkapke & @phillipj