rules: allow GitHub URLs containing hyphens #55
Merged
richardlau merged 2 commits intonodejs:masterfrom May 20, 2019
Merged
Conversation
Extract common code for tests that are expected to pass and tests that are expected to fail to make it easier to add future test cases.
GitHub user and organization names and repository names can contain hyphen characters which are not included in the `\w` regular expression character class.
Merged
Member
|
This fixes #60 and I would like to see it merged. |
Member
Author
|
Ping @nodejs/automation-collaborators for a review. |
evanlucas
approved these changes
May 20, 2019
This was referenced May 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub user and organization names and repository names can contain
hyphen characters which are not included in the
\wregularexpression character class.