ansible: python3 for freebsd (for linting)#1644
Merged
Conversation
cclauss
approved these changes
Dec 19, 2018
cclauss
approved these changes
Dec 19, 2018
Contributor
|
Related to #1639 |
Member
Author
there is a |
Contributor
|
✅ Let's stick with Python 3.6.7. |
thefourtheye
approved these changes
Dec 20, 2018
Contributor
|
✅ This change should enable us to add the command: make lint-py PYTHON=python3 |
Contributor
|
Do we need more approvals on this one? |
|
cc @nodejs/build |
Trott
approved these changes
Dec 26, 2018
|
I believe this is ready to be merged. Can anybody from @nodejs/build take a look at this and merge? |
gdams
approved these changes
Jan 21, 2019
Contributor
|
I'll run the playbook, update the job and if everything goes smoothly I'll merge. |
3 tasks
Contributor
|
So the workers are setup, and the a cloned-edited job works as expected. That is fails with: A PR was opened in upstream WPT repo - web-platform-tests/wpt#14973 |
refack
approved these changes
Jan 21, 2019
Contributor
|
Has been run on worker. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/R= @cclauss