Fix react conflicting peer dependency with react-reconciler#365
Merged
a7ul merged 1 commit intonodegui:masterfrom Jul 7, 2022
Merged
Fix react conflicting peer dependency with react-reconciler#365a7ul merged 1 commit intonodegui:masterfrom
react conflicting peer dependency with react-reconciler#365a7ul merged 1 commit intonodegui:masterfrom
Conversation
a7ul
reviewed
Oct 16, 2021
Reverting back to `react@^16.x.x`. `react-reconciler` should be updated separately so that it can safely be used with `react@17.x.x`. When installing `react-nodegui` as a dependency. It will yield a warning: ``` npm WARN ERESOLVE overriding peer dependency npm WARN While resolving: react-reconciler@0.25.1 npm WARN Found: react@17.0.2 npm WARN node_modules/react npm WARN react@"^17.0.2" from the root project npm WARN 1 more (@nodegui/react-nodegui) npm WARN npm WARN Could not resolve dependency: npm WARN peer react@"^16.13.1" from react-reconciler@0.25.1 npm WARN node_modules/react-reconciler npm WARN react-reconciler@"^0.25.1" from @nodegui/react-nodegui@0.13.0 npm WARN node_modules/@nodegui/react-nodegui npm WARN npm WARN Conflicting peer dependency: react@16.14.0 npm WARN node_modules/react npm WARN peer react@"^16.13.1" from react-reconciler@0.25.1 npm WARN node_modules/react-reconciler npm WARN react-reconciler@"^0.25.1" from @nodegui/react-nodegui@0.13.0 npm WARN node_modules/@nodegui/react-nodegui ```
|
Hi, right now I still have this issue with |
a7ul
approved these changes
Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting back to
react@^16.x.x.react-reconcilershould beupdated separately so that it can safely be used with
react@17.x.x.react-reconcilershould be version0.26.2and requires some refactoring.When installing
react-nodeguias a dependency. It will yield awarning: