Conversation
Contributor
Author
|
Hey @nisrulz. |
nisrulz
reviewed
Sep 24, 2023
Owner
nisrulz
left a comment
nisrulz
left a comment
There was a problem hiding this comment.
Some comments to address. This PR needs some work.
Additionally, also note
- You need to add a link back in readme index
- Update the package name
Contributor
Author
|
Hey @nisrulz. Can you review my changes once again? |
Contributor
Author
|
Hey @nisrulz |
Owner
|
Hi @lutaii I still need to take a look at this PR. I'll try to merge open PRs in the next 2-3 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes
BMI Calculator example
Does this close any currently open issues?
Issue #103
Where has this been tested?
iPhone 14 Pro
Pixel 3A
Target Platform:
iOS/Android
Walkthrough: