Conversation
dd38de7 to
d999e97
Compare
come-nc
left a comment
There was a problem hiding this comment.
I agree with @salmart-dev I think. For the rest, approved.
d999e97 to
c8fd59c
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
…r might on another server Signed-off-by: provokateurin <kate@provokateurin.de>
c8fd59c to
5dbbe2c
Compare
|
Had to rebase due to #57667 adding a test that was failing now. |
|
/backport to stable33 |
|
/backport to stable32 |
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/58689/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 045ad432 5dbbe2cc
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/58689/stable30Error: Failed to check for changes with origin/stable30: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/58689/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 045ad432 5dbbe2cc
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/58689/stable29Error: Failed to check for changes with origin/stable29: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The following sharing chain didn't work before:
Without these fixes step 4 fails:
server/apps/federatedfilesharing/lib/Controller/MountPublicLinkController.php
Line 124 in dd38de7
$share->setId($shareId);to be called on a share that already has an id set, which fails because it's not allowed. The share from user A to user B is also removed due to bad error handling after the exception.I'm afraid the PublicOwnerWrapper is broken as well, because the code doesn't consider that the owner might be a user from a different instance, but I'm not sure if that can be fixed at all without huge changes. Maybe this scenario could be detected and the initiator could be used as a replacement, but that could also have other unintended side effects.