Save the scope of an auth token in the session#3526
Merged
Conversation
icewind1991
force-pushed
the
token-save-scope
branch
2 times, most recently
from
eb6dedc to
06200c2
Compare
Codecov Report
@@ Coverage Diff @@
## master #3526 +/- ##
============================================
+ Coverage 54.03% 54.21% +0.18%
+ Complexity 21300 21199 -101
============================================
Files 1259 1306 +47
Lines 74227 80571 +6344
Branches 0 1250 +1250
============================================
+ Hits 40110 43684 +3574
- Misses 34117 36887 +2770
Continue to review full report at Codecov.
|
LukasReschke
requested changes
Feb 17, 2017
Member
LukasReschke
left a comment
LukasReschke
left a comment
There was a problem hiding this comment.
I'll add an integration test to that before we merge it.
| $session = $this->getSession(); | ||
| $sessionScope = $session->get('token_scope'); | ||
| if ($sessionScope) { | ||
| $this->scope = $sessionScope; |
MorrisJobke
added
2. developing
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
LukasReschke
force-pushed
the
token-save-scope
branch
from
06200c2 to
1d3e391
Compare
LukasReschke
approved these changes
Apr 5, 2017
Member
LukasReschke
left a comment
LukasReschke
left a comment
There was a problem hiding this comment.
Added integration tests for this with 1d3e391. Let's see if they pass :)
rullzer
approved these changes
Apr 5, 2017
Member
|
stable11: #4225 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And re-use the saved scope when no other scope has been set