Make sure ResetTokenBackgroundJob doesn't execute if config is read-only#32584
Merged
Make sure ResetTokenBackgroundJob doesn't execute if config is read-only#32584
Conversation
tcitworld
added
bug
3. to review
tcitworld
requested review from
a team,
ArtificialOwl,
CarlSchwan,
kesselb,
nickvergessen and
vanpertsch
and removed request for
a team
ChristophWurst
approved these changes
May 25, 2022
nickvergessen
approved these changes
May 25, 2022
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
nickvergessen
added
4. to release
kesselb
approved these changes
May 25, 2022
Member
|
/rebase |
nextcloud-command
force-pushed
the
fix-ResetTokenBackgroundJob
branch
from
279e7d6 to
5a6ba44
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Thank you @tcitworld . |
CarlSchwan
approved these changes
Jun 15, 2022
No need to try to delete the config key in config.php if we aren't allowed to. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
force-pushed
the
fix-ResetTokenBackgroundJob
branch
from
5a6ba44 to
956d895
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
/backport to stable23 |
Contributor
|
/backport to stable22 |
This was referenced Jun 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32290