Merged
Conversation
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php
Outdated
Show resolved
Hide resolved
lib/private/DB/QueryBuilder/ExpressionBuilder/OCIExpressionBuilder.php
Outdated
Show resolved
Hide resolved
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 2405: failuresqliteShow full logmariadb10.1-php7.3Show full logmariadb10.4-php7.4Show full logmysql8.0-php7.4Show full logpostgres9.6-php7.3Show full logpostgres11-php7.4Show full logpostgres12-php7.4Show full logpostgres13-php7.4Show full log |
rullzer
force-pushed
the
enh/type/expressionbuilder
branch
from
9f753e2 to
de56159
Compare
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php
Outdated
Show resolved
Hide resolved
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php
Outdated
Show resolved
Hide resolved
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php
Outdated
Show resolved
Hide resolved
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php
Outdated
Show resolved
Hide resolved
lib/private/DB/QueryBuilder/ExpressionBuilder/OCIExpressionBuilder.php
Outdated
Show resolved
Hide resolved
Member
Author
|
Resolved @nickvergessen |
nickvergessen
approved these changes
Mar 3, 2021
Member
|
Time to squash and fixup? |
rullzer
force-pushed
the
enh/type/expressionbuilder
branch
from
22f3b30 to
4bdf9f5
Compare
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
ChristophWurst
approved these changes
Mar 3, 2021
| * @psalm-taint-sink sql $type | ||
| */ | ||
| public function castColumn($column, $type); | ||
| public function castColumn(string $column, $type): IQueryFunction; |
Member
There was a problem hiding this comment.
So before this allowed to also cast "expressions" (like functions).
It was used e.g. in the user_usage_report app:
nextcloud/user_usage_report#69 (comment)
Before:
UPDATE `oc_preferences` SET `configvalue` = (`configvalue` + 1) WHERE (`userid` = :user) AND (`configkey` = :action) AND (`appid` = :appid)After:
UPDATE `oc_preferences` SET `configvalue` = `(`configvalue` + 1)` WHERE (`userid` = :user) AND (`configkey` = :action) AND (`appid` = :appid)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl