fix(export): Handle exceptions when reading file content and ignore whitespace-only files#3214
fix(export): Handle exceptions when reading file content and ignore whitespace-only files#3214Chartman123 wants to merge 1 commit intomainfrom
Conversation
|
@sheyaln could you please try this fix? I don't have access to an instance that uses S3 storage |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
/backport to stable5.2 |
Apologies, how do you recommend I test this fix? |
|
You can go to the Forms app directory on your server and manually patch the lib/service/SubmissionService.php file with the changes from this PR. Make a backup of the original file. You can also apply the patch file https://github.com/nextcloud/forms/pull/3214.patch |
susnux
left a comment
There was a problem hiding this comment.
Nice, just to small comments
…hitespace-only files Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
99f2bca to
604f63d
Compare
@susnux thanks for the review, comments are resolved now :) |
This fixes #3175 by adding a check if the file really has content.
Signed-off-by: Christian Hartmann chris-hartmann@gmx.de