feat: add maximum submissions limit for forms by LAfricain · Pull Request #3199 · nextcloud/forms

LAfricain · 2026-03-03T13:38:11Z

Add the ability to limit the number of responses a form can receive. When the limit is reached, the form is automatically closed and displays a dedicated message instead of accepting new submissions.

Add max_submissions column to forms_v2_forms table (migration)
Add maxSubmissions property to Form entity
Check submission limit in FormsService::canSubmit()
Add limit enforcement in ApiController::newSubmission()
Add isMaxSubmissionsReached flag in form API response
Add limit settings UI in SettingsSidebarTab
Display dedicated 'Form is full' message in Submit view
Add French translations for new strings

Closes #596

Chartman123

@LAfricain thanks for your PR. I just had a quick look at your code and didn't test it yet in my instance. Already a few comments. :)

l10n/fr.js

l10n/fr.json

lib/Controller/ApiController.php

lib/Migration/Version050300Date20250914000000.php

src/components/SidebarTabs/SettingsSidebarTab.vue

src/views/Submit.vue

Chartman123

Some more comments :) Please have a look at the failing workflows, too.

lib/Service/FormsService.php

lib/Controller/ApiController.php

lib/Migration/Version050300Date20260303000000.php

src/components/SidebarTabs/SettingsSidebarTab.vue

LAfricain · 2026-03-07T18:51:41Z

Hello @Chartman123,
I would like to know if everything is ready for a merge or if there are still some improvements to be made?
Thank you in any case for this tool!

Chartman123 · 2026-03-09T12:27:04Z

@LAfricain sorry, I don't have much spare time at the moment :) Please fix the remaining workflow issues

LAfricain · 2026-03-09T19:13:07Z

I don't have much spare time at the moment :)

It's Ok, no rush. I didn't realize I had to fix the errors myself; I still need to get used to the tool. It's done now.

Chartman123 · 2026-03-10T13:52:44Z

@LAfricain yes, you have to fix them yourself (or use the npm scripts and php scripts). Environments like VSCode also can assist you with that :)

codecov · 2026-03-11T14:34:05Z

Codecov Report

❌ Patch coverage is 51.85185% with 13 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
lib/Migration/Version050300Date20260303000000.php	0.00%	10 Missing ⚠️
lib/Controller/ApiController.php	66.66%	1 Missing ⚠️
lib/Service/FormsService.php	83.33%	1 Missing ⚠️
lib/Service/SubmissionService.php	83.33%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Chartman123 · 2026-03-12T20:55:05Z

@LAfricain it's getting better :) only the DCO (sign-off your commits) and OpenAPI missing... Could you then please also squash all your commits into a single one?

Add the ability to limit the number of responses a form can receive. When the limit is reached, the form is automatically closed and displays a dedicated message instead of accepting new submissions. - Add max_submissions column to forms_v2_forms table (migration) - Add maxSubmissions property to Form entity - Check submission limit in FormsService::canSubmit() - Add limit enforcement in ApiController::newSubmission() - Add isMaxSubmissionsReached flag in form API response - Add limit settings UI in SettingsSidebarTab - Display dedicated 'Form is full' message in Submit view - Add French translations for new strings Closes nextcloud#596 Signed-off-by: lafricain79 <lafricain79@gmail.com>

Co-authored-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: L'Africain <fr.cyrille@tiberiade.be> Signed-off-by: lafricain79 <lafricain79@gmail.com>

Signed-off-by: lafricain79 <lafricain79@gmail.com>

Co-authored-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: L'Africain <fr.cyrille@tiberiade.be> Signed-off-by: lafricain79 <lafricain79@gmail.com>

…m type Signed-off-by: lafricain79 <lafricain79@gmail.com>

Signed-off-by: lafricain79 <lafricain79@gmail.com>

…Reached fields Signed-off-by: lafricain79 <lafricain79@gmail.com>

Signed-off-by: lafricain79 <lafricain79@gmail.com>

Signed-off-by: don9x2E <revan@kakao.com>

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: lafricain79 <lafricain79@gmail.com>

Bumps [immutable](https://github.com/immutable-js/immutable-js) from 5.1.4 to 5.1.5. - [Release notes](https://github.com/immutable-js/immutable-js/releases) - [Changelog](https://github.com/immutable-js/immutable-js/blob/main/CHANGELOG.md) - [Commits](immutable-js/immutable-js@v5.1.4...v5.1.5) --- updated-dependencies: - dependency-name: immutable dependency-version: 5.1.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: lafricain79 <lafricain79@gmail.com>

Signed-off-by: nfebe <fenn25.fn@gmail.com> Signed-off-by: lafricain79 <lafricain79@gmail.com>

Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.3.1 to 3.3.2. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.3.1...3.3.2) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.3.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: lafricain79 <lafricain79@gmail.com>

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: lafricain79 <lafricain79@gmail.com>

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 6.2.0 to 6.3.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@6044e13...53b8394) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: 6.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: lafricain79 <lafricain79@gmail.com>

Bumps [@vue/tsconfig](https://github.com/vuejs/tsconfig) from 0.5.1 to 0.9.0. - [Release notes](https://github.com/vuejs/tsconfig/releases) - [Commits](vuejs/tsconfig@v0.5.1...v0.9.0) --- updated-dependencies: - dependency-name: "@vue/tsconfig" dependency-version: 0.9.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: lafricain79 <lafricain79@gmail.com>

Bumps [phpoffice/phpspreadsheet](https://github.com/PHPOffice/PhpSpreadsheet) from 5.4.0 to 5.5.0. - [Release notes](https://github.com/PHPOffice/PhpSpreadsheet/releases) - [Changelog](https://github.com/PHPOffice/PhpSpreadsheet/blob/master/CHANGELOG.md) - [Commits](PHPOffice/PhpSpreadsheet@5.4.0...5.5.0) --- updated-dependencies: - dependency-name: phpoffice/phpspreadsheet dependency-version: 5.5.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: lafricain79 <lafricain79@gmail.com>

Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: lafricain79 <lafricain79@gmail.com>

This reverts commit cf200d1. Signed-off-by: lafricain79 <lafricain79@gmail.com>

…onShort components Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: lafricain79 <lafricain79@gmail.com>

…issionsReached fields Signed-off-by: lafricain79 <lafricain79@gmail.com>

Signed-off-by: lafricain79 <lafricain79@gmail.com>

Chartman123 · 2026-03-12T22:03:20Z

Oh, please don't merge the main branch into this PR, always use git rebase -i main. There you can also squash the commits into a single one :)

Signed-off-by: lafricain79 <lafricain79@gmail.com>

Chartman123 requested changes Mar 3, 2026

View reviewed changes

Chartman123 added enhancement New feature or request 2. developing Work in progress feature: 📝 submitting responses labels Mar 3, 2026

Chartman123 added this to the 5.3 milestone Mar 3, 2026

Chartman123 requested changes Mar 3, 2026

View reviewed changes

lib/Service/FormsService.php Show resolved Hide resolved

lib/Controller/ApiController.php Outdated Show resolved Hide resolved

lib/Controller/ApiController.php Show resolved Hide resolved

lib/Migration/Version050300Date20260303000000.php Show resolved Hide resolved

Chartman123 reviewed Mar 3, 2026

View reviewed changes

src/components/SidebarTabs/SettingsSidebarTab.vue Outdated Show resolved Hide resolved

lafricain79 and others added 17 commits March 12, 2026 22:59

Update src/components/SidebarTabs/SettingsSidebarTab.vue

1928ced

Co-authored-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: L'Africain <fr.cyrille@tiberiade.be> Signed-off-by: lafricain79 <lafricain79@gmail.com>

Update src/components/SidebarTabs/SettingsSidebarTab.vue

46bed8a

Co-authored-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: L'Africain <fr.cyrille@tiberiade.be> Signed-off-by: lafricain79 <lafricain79@gmail.com>

Update src/views/Submit.vue

b4b9b7d

Co-authored-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: L'Africain <fr.cyrille@tiberiade.be> Signed-off-by: lafricain79 <lafricain79@gmail.com>

fix: revert manual changes to l10n files

a5f9e84

Signed-off-by: lafricain79 <lafricain79@gmail.com>

refactor: move schema change to a new migration file

633aa7d

Signed-off-by: lafricain79 <lafricain79@gmail.com>

fix: treat zero and null as unlimited for max submissions

e25242b

Signed-off-by: lafricain79 <lafricain79@gmail.com>

refactor: remove default value and custom CSS for max submissions input

9a5de96

Signed-off-by: lafricain79 <lafricain79@gmail.com>

fix: set default value to 1 when enabling max submissions

16ef41e

Signed-off-by: lafricain79 <lafricain79@gmail.com>

refactor: use NcInputField instead of native input for max submissions

3c9da6a

Signed-off-by: lafricain79 <lafricain79@gmail.com>

Update lib/Migration/Version050300Date20260303000000.php

7e7a467

Co-authored-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: L'Africain <fr.cyrille@tiberiade.be> Signed-off-by: lafricain79 <lafricain79@gmail.com>

Update lib/Service/FormsService.php

7b599fe

Co-authored-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: L'Africain <fr.cyrille@tiberiade.be> Signed-off-by: lafricain79 <lafricain79@gmail.com>

Update lib/Controller/ApiController.php

c42fe3f

Co-authored-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: L'Africain <fr.cyrille@tiberiade.be> Signed-off-by: lafricain79 <lafricain79@gmail.com>

Update lib/Controller/ApiController.php

8872bec

Co-authored-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: L'Africain <fr.cyrille@tiberiade.be> Signed-off-by: lafricain79 <lafricain79@gmail.com>

fix: add maxSubmissions and isMaxSubmissionsReached to FormsForm psal…

15c036e

…m type Signed-off-by: lafricain79 <lafricain79@gmail.com>

fix: fix ESLint formatting issues

c9cbd85

Signed-off-by: lafricain79 <lafricain79@gmail.com>

fix: fix PHP CS formatting in migration file

faeca84

Signed-off-by: lafricain79 <lafricain79@gmail.com>

lafricain79 and others added 19 commits March 12, 2026 22:59

fix: update unit tests to include maxSubmissions and isMaxSubmissions…

84a4324

…Reached fields Signed-off-by: lafricain79 <lafricain79@gmail.com>

fix: fix remaining ESLint errors

b4da0f5

Signed-off-by: lafricain79 <lafricain79@gmail.com>

fix: update FormsMigratorTest to include maxSubmissions field

4fe2109

Signed-off-by: lafricain79 <lafricain79@gmail.com>

fix: require explicit intent for option creation (IME safe)

1f51e8d

Signed-off-by: don9x2E <revan@kakao.com>

fix: Improve validation for submission answers with strict type checking

108fc6b

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: lafricain79 <lafricain79@gmail.com>

chore: Support NC34

c984088

Signed-off-by: nfebe <fenn25.fn@gmail.com> Signed-off-by: lafricain79 <lafricain79@gmail.com>

v5.2.5 changelog

7b44634

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: lafricain79 <lafricain79@gmail.com>

fix(l10n): Update translations from Transifex

0c06a65

Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: lafricain79 <lafricain79@gmail.com>

fix(l10n): Update translations from Transifex

bb7e08d

Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: lafricain79 <lafricain79@gmail.com>

fix(l10n): Update translations from Transifex

008cf47

Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: lafricain79 <lafricain79@gmail.com>

Revert "Chore(deps-dev): Bump @vue/tsconfig from 0.5.1 to 0.9.0"

ef9de32

This reverts commit cf200d1. Signed-off-by: lafricain79 <lafricain79@gmail.com>

fix(a11y): Prevent escaping of aria-labels in QuestionLong and Questi…

ef9189c

…onShort components Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: lafricain79 <lafricain79@gmail.com>

fix: update integration tests to include maxSubmissions and isMaxSubm…

fb7b940

…issionsReached fields Signed-off-by: lafricain79 <lafricain79@gmail.com>

fix: regenerate openapi.json

0f256fc

Signed-off-by: lafricain79 <lafricain79@gmail.com>

LAfricain force-pushed the maxsubmissions branch from 4e655a8 to 0f256fc Compare March 12, 2026 22:02

fix: resolve merge conflict in AnswerInput.vue

a842d93

Signed-off-by: lafricain79 <lafricain79@gmail.com>

Conversation

LAfricain commented Mar 3, 2026

Uh oh!

Chartman123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Chartman123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LAfricain commented Mar 7, 2026

Uh oh!

Chartman123 commented Mar 9, 2026

Uh oh!

LAfricain commented Mar 9, 2026

Uh oh!

Chartman123 commented Mar 10, 2026

Uh oh!

codecov bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Chartman123 commented Mar 12, 2026

Uh oh!

Chartman123 commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Mar 11, 2026 •

edited

Loading