Conversation
Chartman123
reviewed
Dec 13, 2024
Collaborator
Chartman123
left a comment
Chartman123
left a comment
There was a problem hiding this comment.
@hamza221 Thank you very much :)
Please fix the remaining issues regarding prettier and I'm unsure where the failing tests are coming from...
Chartman123
reviewed
Dec 16, 2024
hamza221
force-pushed
the
chore/noid/spdx
branch
from
a7efe85 to
d802194
Compare
Contributor
Author
|
I'm not sure what's wrong with the unit tests , reuse Job is not reading the reuse.toml for some reason I'll try investigating |
Chartman123
reviewed
Dec 16, 2024
Contributor
Author
|
blocked by #2466 |
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
hamza221
force-pushed
the
chore/noid/spdx
branch
from
b270aff to
e594064
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2455 +/- ##
=========================================
Coverage 44.27% 44.27%
Complexity 860 860
=========================================
Files 73 73
Lines 3268 3268
=========================================
Hits 1447 1447
Misses 1821 1821 |
Chartman123
approved these changes
Dec 17, 2024
Collaborator
Chartman123
left a comment
Chartman123
left a comment
There was a problem hiding this comment.
Great, looks good now :) Thank you very much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2357