Add ability to force upgrades even when Nextcloud version did not change#2403
Open
boomer41 wants to merge 3 commits intonextcloud:masterfrom
Open
Add ability to force upgrades even when Nextcloud version did not change#2403boomer41 wants to merge 3 commits intonextcloud:masterfrom
boomer41 wants to merge 3 commits intonextcloud:masterfrom
Conversation
Allow execution of scripts even before the need to install or update Nextcloud is determined. Useful when needing to have additional update condition checks. Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
… tmp folder We have a custom image where we'd like to recopy all of nextcloud's source code again when we update some internal thing without a change in Nextcloud's version. The newly added pre-initialization hook can be used to determine this and force a rerun. Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
Author
|
Any updates on this PR from the maintainers? :) |
Author
|
Can someone from the maintainers look at these PRs, please? :) Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd like to bundle custom apps into the image by extending it.
However, we ran into issues when we want to push an update to an app in the image when the Nextcloud version did not change.
We solved that by
pre-initializationthat runs even before the need for an initialization/upgrade is determined, and/tmp/nextcloud-force-initializationexists.The later can be dynamically created by a script triggered the new hook mentioned above.
With this setup, the script can then additionally start an initialization run.
When the initialization is finished, the marker file is automatically removed.
The script can not stop an upgrade from happening, it can only additionally start one.