Open
Conversation
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
luka-nextcloud
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
luka-nextcloud
force-pushed
the
fix-share-and-assign-team
branch
from
0ccb3e7 to
9771207
Compare
Signed-off-by: Luka Trovic <luka@nextcloud.com>
luka-nextcloud
force-pushed
the
fix-share-and-assign-team
branch
from
9771207 to
d76c1bb
Compare
Contributor
|
🐢 Performance warning. |
grnd-alt
requested changes
Mar 9, 2026
Member
grnd-alt
left a comment
grnd-alt
left a comment
There was a problem hiding this comment.
the failing phpunit tests say findAll called more than once, we're already querying for all acls in line 117, why not store and use again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist