fix: Handle share attributes in the share provider#7659
Merged
Conversation
Signed-off-by: Julius Knorr <jus@bitgrid.net>
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
grnd-alt
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
blizzz
approved these changes
Feb 24, 2026
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
Approved with some suggestions and remarks, that have not much to do with this changes her per se, by-catch.
| $share->getAttributes() | ||
| ); | ||
|
|
||
| $shareId = $this->addShareToDB( |
Member
There was a problem hiding this comment.
this method leaves me puzzled, but out of scope in this PR
| $cursor->closeCursor(); | ||
| } | ||
|
|
||
| protected function updateShareAttributes(IShare $share, ?string $data): IShare { |
Member
There was a problem hiding this comment.
Strictly speaking, here we would not need the return type as the method works on the passed IShare object. In a functional programming approach a clone would be returned that was worked on, so might be a source of confusion. But certainly not the only place, so nothing to act on necessarily.
Signed-off-by: grnd-alt <git@belakkaf.net>
github-project-automation
bot
moved this from 👀 In review
to ☑️ Done
in 📝 Productivity team
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
This was referenced Mar 9, 2026
Member
Author
|
/backport to stable30 |
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.