Change sharees format by tobiasKaminsky · Pull Request #325 · nextcloud/android-library

tobiasKaminsky · 2019-07-31T12:14:19Z

Needs: nextcloud/server#14429
Only merge if this is in NC17, otherwise change it.

Needs new server image, as it needs
user1, displayName: "User One"
user2, displayName: "User Two"
users group: with user1, user2

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

codecov · 2019-07-31T15:51:09Z

Codecov Report

Merging #325 into master will increase coverage by 3.79%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   21.58%   25.38%   +3.79%     
==========================================
  Files         117      118       +1     
  Lines        5166     5220      +54     
  Branches      701      711      +10     
==========================================
+ Hits         1115     1325     +210     
+ Misses       3921     3735     -186     
- Partials      130      160      +30

Impacted Files	Coverage Δ
...owncloud/android/lib/resources/shares/OCShare.java	`26.6% <0%> (+26.6%)`	⬆️
...android/lib/common/operations/RemoteOperation.java	`9.52% <0%> (ø)`	⬆️
...cloud/android/lib/resources/shares/ShareeUser.java	`18.18% <18.18%> (ø)`
...ncloud/android/lib/resources/shares/ShareType.java	`69.56% <30%> (+69.56%)`	⬆️
.../android/lib/resources/files/model/RemoteFile.java	`41.5% <33.33%> (+0.94%)`	⬆️
...ncloud/android/lib/common/network/WebdavEntry.java	`72.36% <82.35%> (+2.9%)`	⬆️
...ces/shares/ShareToRemoteOperationResultParser.java	`41.93% <0%> (+41.93%)`	⬆️
...d/android/lib/resources/shares/ShareXMLParser.java	`47.82% <0%> (+47.82%)`	⬆️
... and 2 more

tobiasKaminsky · 2019-08-06T13:46:39Z

IT test failed: kaminsky.me/nc-dev/library-integrationTests/1155

This currently cannot work as server PR needs first to be merged.

AndyScherzinger · 2019-08-20T08:39:46Z

src/main/java/com/owncloud/android/lib/common/network/WebdavEntry.java

    }
+
+    private @Nullable
+    ShareeUser createShareeUser(Element element) {


should be a single line

private @Nullable ShareeUser createShareeUser(Element element) {

AndyScherzinger

just a minor formatting comment

nextcloud-android-bot · 2019-08-20T13:56:35Z

IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1180

nextcloud-android-bot · 2019-08-20T14:07:34Z

Lint

Type	master	PR
Warnings	0	0
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	15
Correctness Warnings	43
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	16
Security Warnings	17
Dodgy code Warnings	81
Total	188

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	40
Internationalization Warnings	6
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	3
Performance Warnings	16
Security Warnings	17
Dodgy code Warnings	81
Total	181

SpotBugs increased!

nextcloud-android-bot · 2019-08-20T14:40:55Z

IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1182

nextcloud-android-bot · 2019-08-20T14:45:37Z

IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1183

nextcloud-android-bot · 2019-08-20T14:58:53Z

Lint

Type	master	PR
Warnings	0	0
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	15
Correctness Warnings	43
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	16
Security Warnings	17
Dodgy code Warnings	81
Total	188

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	40
Internationalization Warnings	6
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	3
Performance Warnings	16
Security Warnings	17
Dodgy code Warnings	81
Total	181

SpotBugs increased!

nextcloud-android-bot · 2019-08-20T15:04:03Z

Lint

Type	master	PR
Warnings	0	0
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	15
Correctness Warnings	43
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	16
Security Warnings	17
Dodgy code Warnings	81
Total	188

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	40
Internationalization Warnings	6
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	3
Performance Warnings	16
Security Warnings	17
Dodgy code Warnings	81
Total	181

SpotBugs increased!

nextcloud-android-bot · 2019-08-20T16:15:11Z

Lint

Type	master	PR
Warnings	0	0
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	15
Correctness Warnings	39
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	17
Dodgy code Warnings	81
Total	185

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	40
Internationalization Warnings	6
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	3
Performance Warnings	16
Security Warnings	17
Dodgy code Warnings	81
Total	181

SpotBugs increased!

nextcloud-android-bot · 2019-08-21T06:05:24Z

Lint

Type	master	PR
Warnings	0	1
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	15
Correctness Warnings	39
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	17
Dodgy code Warnings	81
Total	185

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	40
Internationalization Warnings	6
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	3
Performance Warnings	16
Security Warnings	17
Dodgy code Warnings	81
Total	181

Lint increased!

- add ShareeUser, with userId and displayName - add tests - add group support - no need of own hashCode create user/group in drone Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

nextcloud-android-bot · 2019-08-21T10:47:07Z

Lint

Type	master	PR
Warnings	0	0
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	15
Correctness Warnings	39
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	17
Security Warnings	17
Dodgy code Warnings	81
Total	185

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	40
Internationalization Warnings	6
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	3
Performance Warnings	16
Security Warnings	17
Dodgy code Warnings	81
Total	181

tobiasKaminsky added 3. to review client change required labels Jul 31, 2019

AndyScherzinger previously approved these changes Aug 1, 2019

View reviewed changes

tobiasKaminsky mentioned this pull request Aug 6, 2019

Sharees will be in NC17 nextcloud/android#4284

Merged

4 tasks

tobiasKaminsky dismissed AndyScherzinger’s stale review via ed1103d August 6, 2019 12:42

nextcloud deleted a comment Aug 6, 2019

AndyScherzinger previously approved these changes Aug 6, 2019

View reviewed changes

tobiasKaminsky dismissed AndyScherzinger’s stale review via 2e7b50d August 7, 2019 08:23

nextcloud deleted a comment Aug 7, 2019

nextcloud deleted a comment Aug 19, 2019

tobiasKaminsky force-pushed the adaptSharees branch from dcc2611 to 5f30580 Compare August 19, 2019 07:11

nextcloud deleted a comment Aug 19, 2019

AndyScherzinger previously approved these changes Aug 19, 2019

View reviewed changes

tobiasKaminsky dismissed AndyScherzinger’s stale review via 20ee387 August 20, 2019 07:19

tobiasKaminsky force-pushed the adaptSharees branch 2 times, most recently from 20ee387 to cb58df5 Compare August 20, 2019 07:22

nextcloud deleted a comment Aug 20, 2019

AndyScherzinger reviewed Aug 20, 2019

View reviewed changes

AndyScherzinger previously approved these changes Aug 20, 2019

View reviewed changes

tobiasKaminsky dismissed AndyScherzinger’s stale review via f14b00e August 20, 2019 11:39

tobiasKaminsky force-pushed the adaptSharees branch from f14b00e to bd47e7e Compare August 20, 2019 12:16

nextcloud deleted a comment Aug 20, 2019

tobiasKaminsky force-pushed the adaptSharees branch from bd47e7e to 1e7e1f6 Compare August 20, 2019 13:14

tobiasKaminsky force-pushed the adaptSharees branch from 1e7e1f6 to f592545 Compare August 20, 2019 13:58

tobiasKaminsky force-pushed the adaptSharees branch from f592545 to 14f2b85 Compare August 20, 2019 14:41

tobiasKaminsky force-pushed the adaptSharees branch 3 times, most recently from 69b1246 to 828e6a9 Compare August 20, 2019 14:48

nextcloud deleted a comment Aug 20, 2019

tobiasKaminsky force-pushed the adaptSharees branch from 828e6a9 to e2b8892 Compare August 20, 2019 15:13

tobiasKaminsky force-pushed the adaptSharees branch from e2b8892 to c425a43 Compare August 21, 2019 05:46

nextcloud deleted a comment Aug 21, 2019

Change sharees format

a219fbe

- add ShareeUser, with userId and displayName - add tests - add group support - no need of own hashCode create user/group in drone Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

tobiasKaminsky force-pushed the adaptSharees branch from c425a43 to a219fbe Compare August 21, 2019 10:04

nextcloud deleted a comment Aug 21, 2019

tobiasKaminsky removed the client change required label Aug 21, 2019

tobiasKaminsky merged commit 4a1ab72 into master Aug 21, 2019

tobiasKaminsky deleted the adaptSharees branch August 21, 2019 11:04

AndyScherzinger added this to the NC Android lib 1.6.0 milestone Aug 21, 2019

Conversation

tobiasKaminsky commented Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tobiasKaminsky commented Aug 6, 2019

Uh oh!

AndyScherzinger Aug 20, 2019

Choose a reason for hiding this comment

Uh oh!

AndyScherzinger left a comment

Choose a reason for hiding this comment

Uh oh!

nextcloud-android-bot commented Aug 20, 2019

Uh oh!

nextcloud-android-bot commented Aug 20, 2019

Lint

SpotBugs (new)

SpotBugs (master)

SpotBugs increased!

Uh oh!

nextcloud-android-bot commented Aug 20, 2019

Uh oh!

nextcloud-android-bot commented Aug 20, 2019

Uh oh!

nextcloud-android-bot commented Aug 20, 2019

Lint

SpotBugs (new)

SpotBugs (master)

SpotBugs increased!

Uh oh!

nextcloud-android-bot commented Aug 20, 2019

Lint

SpotBugs (new)

SpotBugs (master)

SpotBugs increased!

Uh oh!

nextcloud-android-bot commented Aug 20, 2019

Lint

SpotBugs (new)

SpotBugs (master)

SpotBugs increased!

Uh oh!

nextcloud-android-bot commented Aug 21, 2019

Lint

SpotBugs (new)

SpotBugs (master)

Lint increased!

Uh oh!

nextcloud-android-bot commented Aug 21, 2019

Lint

SpotBugs (new)

SpotBugs (master)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tobiasKaminsky commented Jul 31, 2019 •

edited

Loading

codecov bot commented Jul 31, 2019 •

edited

Loading