Skip to content

GetJsonValueByKey throws better message #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
y423610m wants to merge 2 commits into
base: master
Choose a base branch
from
Open

GetJsonValueByKey throws better message #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b84daa
GetJsonValueByKey throws better message
Mar 4, 2026
483b693
bump version
Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 0.82.4 (2026-03-04)

- Improve GetJsonValueByKey exception message to mention expected key and type.

## 0.82.3 (2026-02-04)

- Set Accept-Encoding:gzip if the linked libcurl supports it
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ set( CMAKE_ALLOW_LOOSE_LOOP_CONSTRUCTS TRUE )
# make sure to change the version in docs/Makefile
set (MUJINCLIENT_VERSION_MAJOR 0)
set (MUJINCLIENT_VERSION_MINOR 82)
set (MUJINCLIENT_VERSION_PATCH 3)
set (MUJINCLIENT_VERSION_PATCH 4)
set (MUJINCLIENT_VERSION ${MUJINCLIENT_VERSION_MAJOR}.${MUJINCLIENT_VERSION_MINOR}.${MUJINCLIENT_VERSION_PATCH})
set (MUJINCLIENT_SOVERSION ${MUJINCLIENT_VERSION_MAJOR}.${MUJINCLIENT_VERSION_MINOR})
set (CLIENT_SOVERSION ${MUJINCLIENT_VERSION_MAJOR}.${MUJINCLIENT_VERSION_MINOR})
Expand Down
2 changes: 1 addition & 1 deletion include/mujincontrollerclient/mujinjson.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,7 +1122,7 @@ inline void LoadJsonValueByPath(const rapidjson::GenericValue<Encoding, Allocato
template<typename T, typename U, typename Encoding=rapidjson::UTF8<>, typename Allocator=rapidjson::MemoryPoolAllocator<> >
T GetJsonValueByKey(const rapidjson::GenericValue<Encoding, Allocator>& v, const char* key, const U& t) {
if (!v.IsObject()) {
throw MujinJSONException("Cannot get value of non-object.");
throw MujinJSONException("Cannot get value of non-object (\"" + std::string(GetJsonTypeName(v)) + "\") for key \"" + std::string(key) + "\".");
}

typename rapidjson::GenericValue<Encoding, Allocator>::ConstMemberIterator itMember = v.FindMember(key);
Expand Down