suppor lora loading from state dict

[qzzz95]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @qzzz95, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant refactoring of the LoRA (Low-Rank Adaptation) loading mechanism. The primary goal is to enhance the flexibility and modularity of how LoRA weights are integrated into the system. By separating the concerns of file I/O from the actual application of LoRA weights, the updated architecture allows for direct loading of LoRA state dictionaries, paving the way for more diverse and efficient LoRA management strategies. This change improves the robustness of the LoRA loading process and provides a clearer internal structure.

Highlights

• Refactored LoRA Loading: The core logic for applying LoRA weights has been extracted into a new private method, _load_lora_state_dicts, which now directly accepts pre-loaded PyTorch state dictionaries.
• Flexible Input for LoRA: The public load_loras method has been updated to prepare LoRA state dictionaries from file paths and then pass them to the new internal method, enabling future support for loading LoRA weights from various sources beyond just file paths.
• Improved Type Handling: Added explicit type checking for lora_item to ensure it is either a float or a LoraConfig instance, providing better error handling.
• Enhanced Logging: Updated logging messages to clearly indicate when LoRA weights are being loaded from a state dictionary and to show the associated scale.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the LoRA loading mechanism to support loading from a state dictionary. The existing load_loras method is preserved for backward compatibility, now acting as a wrapper that loads LoRA from file paths and delegates to a new internal method _load_lora_state_dicts. The changes are well-structured and improve robustness by adding better type checking. I have one suggestion to remove a redundant logging statement to keep the logs clean.