Conversation
Summary of ChangesHello @akaitsuki-ii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue related to the compilation of transformer blocks by adjusting the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses an issue with compiling repeated blocks. The change in diffsynth_engine/models/flux/flux_dit.py correctly adds compilation for single_blocks, which was previously missing. The change in diffsynth_engine/models/wan/wan_dit.py removes an erroneous loop over single_blocks, which do not exist in that class, thus preventing a potential AttributeError. Both changes are correct and improve the code's robustness. I've included one suggestion to improve code conciseness.
| for block in self.blocks: | ||
| block.compile(*args, **kwargs) | ||
|
|
||
| for block in self.single_blocks: | ||
| block.compile(*args, **kwargs) |
There was a problem hiding this comment.
For conciseness, you can combine the two loops into a single one. nn.ModuleList supports concatenation using the + operator, which makes the code more readable.
| for block in self.blocks: | |
| block.compile(*args, **kwargs) | |
| for block in self.single_blocks: | |
| block.compile(*args, **kwargs) | |
| for block in self.blocks + self.single_blocks: | |
| block.compile(*args, **kwargs) |
No description provided.