Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

Refactor unit tests#201

Merged
mingxwa merged 2 commits intomicrosoft:mainfrom
mingxwa:user/mingxwa/refactor-tests
Nov 19, 2024
Merged

Refactor unit tests#201
mingxwa merged 2 commits intomicrosoft:mainfrom
mingxwa:user/mingxwa/refactor-tests

Conversation

@mingxwa
Copy link
Contributor

@mingxwa mingxwa commented Nov 18, 2024

Ported unit tests refactoring from #199.

Changes

  • Moved some types out of an anonymous namespace in unit tests to avoid generating warnings of unused variables in a debug build.
  • Removed some warning suppressions in unit tests accordingly.

@mingxwa mingxwa requested review from guominrui and tian-lt November 18, 2024 14:16
@mingxwa mingxwa merged commit b61bab4 into microsoft:main Nov 19, 2024
@mingxwa mingxwa deleted the user/mingxwa/refactor-tests branch November 19, 2024 06:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@tian-lt tian-lt tian-lt approved these changes

@guominrui guominrui guominrui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mingxwa @tian-lt @guominrui