This repository was archived by the owner on Jan 29, 2026. It is now read-only.
Resolve build issues for NVHPC#182
Merged
mingxwa merged 2 commits intomicrosoft:mainfrom Oct 22, 2024
Merged
Conversation
Closed
tian-lt
approved these changes
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #180
Changes
proxywhen no dispatch is specified, causing static assertions to fail. Although this is a QoI issue for the compiler, we have worked around this by specifying a different base type forproxyin this case.inline constvariable asconstexpr, causingstatic_assert(!pro::facade<BadFacade_BadConstraints_NotConstant>)to fail. This should be a bug in NVHPC. I simply worked around the issue in this change by splitting the definition of the variable from its declaration.static_cast, causingProxyLifetimeTests.Test_DirectConvension_LvalueandProxyLifetimeTests.Test_DirectConvension_Rvalueto fail. This is a bug in the existing unit test implementation since copy elision is not guaranteed forstatic_cast.tests/CMakeLists.txtto exclude freestanding test cases from unsupported compilers like NVHPC.Notes