Skip to content

Comments

wclayer: Work around Windows bug when expanding sandbox size#718

Merged
jterry75 merged 1 commit intomicrosoft:masterfrom
jstarks:workaround_expandlayer
Oct 21, 2019
Merged

wclayer: Work around Windows bug when expanding sandbox size#718
jterry75 merged 1 commit intomicrosoft:masterfrom
jstarks:workaround_expandlayer

Conversation

@jstarks
Copy link
Member

@jstarks jstarks commented Oct 17, 2019

This change works around a bug in Windows where a sandbox VHDX that has
been resized cannot be successfully mounted. This is due to a failure in
the path that resizes the NTFS volume inside the VHDX during the sandbox
mount process. To work around this, manually expand the volume in the
wclayer package just after making the call to expand the VHDX.

This change hurts the performance of the resize operation on affected
Windows hosts (19H1 and prerelease versions of Vb) and should be
reverted once the Windows bug has been fixed and is widely deployed.

This should provide a workaround for #708.

@jstarks jstarks force-pushed the workaround_expandlayer branch from ba4ca33 to 164f6a7 Compare October 17, 2019 16:58
@jstarks
wclayer: Work around Windows bug when expanding sandbox size
d2042e6 
This change works around a bug in Windows where a sandbox VHDX that has
been resized cannot be successfully mounted. This is due to a failure in
the path that resizes the NTFS volume inside the VHDX during the sandbox
mount process. To work around this, manually expand the volume in the
wclayer package just after making the call to expand the VHDX.

This change hurts the performance of the resize operation on affected
Windows hosts (19H1 and prerelease versions of Vb) and should be
reverted once the Windows bug has been fixed and is widely deployed.
@jstarks jstarks force-pushed the workaround_expandlayer branch from 164f6a7 to d2042e6 Compare October 17, 2019 17:00
jterry75
jterry75 approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you open a work item to revert this pending some future when the Windows fix is released.

@jstarks jstarks mentioned this pull request Oct 18, 2019
Closed
@jterry75 jterry75 mentioned this pull request Oct 18, 2019
Closed
@jstarks
Copy link
Member Author

jstarks commented Oct 18, 2019

Can we merge this? Can someone work to get this integrated into Moby?

@vikramhh
Copy link

vikramhh commented Oct 18, 2019

@jstarks - I can work on getting this integrated into Moby once the merge goes through.

@jterry75 jterry75 merged commit d2849cb into microsoft:master Oct 21, 2019
@jterry75
Copy link
Contributor

jterry75 commented Oct 21, 2019 •
edited
Loading

@vikramhh - Can you update vendor and run CI? This will be more code changes than just this PR in the vendor update so want to make sure we didnt regress anything. If you find anything I will look asap

@vikramhh vikramhh mentioned this pull request Oct 24, 2019
Closed
1 task
@thaJeztah thaJeztah mentioned this pull request Oct 24, 2019
Closed
vikramhh pushed a commit to vikramhh/moby that referenced this pull request Nov 11, 2019
Bump hcsshim to 6c7177eae8be632af2e15e44b62d69ab18389ddb
51d49a8 
Among other things, this is required to pull in
microsoft/hcsshim#718 which should
take care of multiple issues reported to us.

Signed-off-by: Vikram bir Singh <vikrambir.singh@docker.com>
vikramhh pushed a commit to vikramhh/moby that referenced this pull request Nov 25, 2019
Bump hcsshim to b3f49c06ffaeef24d09c6c08ec8ec8425a
e09e962 
Among other things, this is required to pull in
microsoft/hcsshim#718 which should
take care of multiple issues reported to us.

Also fixes microsoft/hcsshim#737
which was caught by checks while attempting to bump
up hcsshim version.

Modifies TestRunAttachFailedNoLeak to do case-insensitive
comparison to fix a failure on RS1.

Signed-off-by: Vikram bir Singh <vikrambir.singh@docker.com>
vikramhh pushed a commit to vikramhh/moby that referenced this pull request Nov 25, 2019
Bump hcsshim to b3f49c06ffaeef24d09c6c08ec8ec8425a
a7b6c3f 
Among other things, this is required to pull in
microsoft/hcsshim#718

Also fixes microsoft/hcsshim#737
which was caught by checks while attempting to bump
up hcsshim version.

Signed-off-by: Vikram bir Singh <vikrambir.singh@docker.com>
@vikramhh vikramhh mentioned this pull request Nov 26, 2019
Merged
1 task
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Nov 26, 2019
Bump hcsshim to b3f49c06ffaeef24d09c6c08ec8ec8425a
758feda 
Among other things, this is required to pull in
microsoft/hcsshim#718

Also fixes microsoft/hcsshim#737
which was caught by checks while attempting to bump
up hcsshim version.

Signed-off-by: Vikram bir Singh <vikrambir.singh@docker.com>
Upstream-commit: a7b6c3f0bf5d10c6227a29bac7dd46b9a7a779bc
Component: engine
thaJeztah pushed a commit to thaJeztah/docker that referenced this pull request Dec 3, 2019
@thaJeztah
Bump hcsshim to b3f49c06ffaeef24d09c6c08ec8ec8425a
e2f226b 
Among other things, this is required to pull in
microsoft/hcsshim#718

Also fixes microsoft/hcsshim#737
which was caught by checks while attempting to bump
up hcsshim version.

Signed-off-by: Vikram bir Singh <vikrambir.singh@docker.com>
(cherry picked from commit a7b6c3f)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah mentioned this pull request Dec 3, 2019
Merged
@PatrickLang
Copy link

PatrickLang commented Dec 4, 2019

Does anyone have an ETA on the Windows fix? I just hit this with Docker for Windows (19.03.5) running on Windows 10 1909 (18363.476)

thaJeztah added a commit to thaJeztah/cli that referenced this pull request Jan 7, 2020
@thaJeztah
vendor: bump hcsshim b3f49c06ffaeef24d09c6c08ec8ec8425a0303e2
dff269b 
full diff: https://2226e083fc390003ae5aa8325c3c92789afa0e7a...b3f49c06ffaeef24d09c6c08ec8ec8425a0303e2

includes:

- microsoft/hcsshim#718 wclayer: Work around Windows bug when expanding sandbox size
    - fixes microsoft/hcsshim#708 Windows Host Compute Service bug breaks docker (and other) sandboxes bigger than 20G on Windows 1903
    - fixes microsoft/hcsshim#624The hcsshim on Windows 10 1903 always fails to build Docker image
    - fixes/addresses docker/for-win#3884 An error occurred while attempting to build Docker image (especially this comment and the next comments after: docker/for-win#3884 (comment))
    - fixes/addresses docker/for-win#4100 Windows 1903 fails when storage-opt used
    - fixes moby/moby#36831 hcsshim::PrepareLayer failed in Win32: The parameter is incorrect (moby/moby#36831 (comment))
    - fixes Stannieman/audacity-with-asio-builder#5 Docker won't build container
    - fixes MicrosoftDocs/visualstudio-docs#3523 Error when running build with storage-opts set
    - fixes moby/moby#39524 Docker build windows 19.03 --storage-opt size>20G

Note that this is a temporary workaround for a bug in the platform, and will be reverted once that is addressed:

- microsoft/hcsshim#721 Revert 718 when Windows 19H1 has expand sandbox fix

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah mentioned this pull request Jan 7, 2020
Merged
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Jan 9, 2020
@thaJeztah
vendor: bump hcsshim b3f49c06ffaeef24d09c6c08ec8ec8425a0303e2
26dc16f 
full diff: https://2226e083fc390003ae5aa8325c3c92789afa0e7a...b3f49c06ffaeef24d09c6c08ec8ec8425a0303e2

includes:

- microsoft/hcsshim#718 wclayer: Work around Windows bug when expanding sandbox size
    - fixes microsoft/hcsshim#708 Windows Host Compute Service bug breaks docker (and other) sandboxes bigger than 20G on Windows 1903
    - fixes microsoft/hcsshim#624The hcsshim on Windows 10 1903 always fails to build Docker image
    - fixes/addresses docker/for-win#3884 An error occurred while attempting to build Docker image (especially this comment and the next comments after: docker/for-win#3884 (comment))
    - fixes/addresses docker/for-win#4100 Windows 1903 fails when storage-opt used
    - fixes moby/moby#36831 hcsshim::PrepareLayer failed in Win32: The parameter is incorrect (moby/moby#36831 (comment))
    - fixes Stannieman/audacity-with-asio-builder#5 Docker won't build container
    - fixes MicrosoftDocs/visualstudio-docs#3523 Error when running build with storage-opts set
    - fixes moby/moby#39524 Docker build windows 19.03 --storage-opt size>20G

Note that this is a temporary workaround for a bug in the platform, and will be reverted once that is addressed:

- microsoft/hcsshim#721 Revert 718 when Windows 19H1 has expand sandbox fix

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: dff269b5e4b8dc86d12116ac5dff9caca49593d9
Component: cli
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Jan 23, 2020
@thaJeztah
Bump hcsshim to b3f49c06ffaeef24d09c6c08ec8ec8425a
93bf0c9 
Among other things, this is required to pull in
microsoft/hcsshim#718

Also fixes microsoft/hcsshim#737
which was caught by checks while attempting to bump
up hcsshim version.

Signed-off-by: Vikram bir Singh <vikrambir.singh@docker.com>
(cherry picked from commit a7b6c3f0bf5d10c6227a29bac7dd46b9a7a779bc)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: e2f226b5b41c958fa518f677eb213eb1462f90a8
Component: engine
@thaJeztah thaJeztah mentioned this pull request Mar 9, 2020
Open
@TBBle TBBle mentioned this pull request May 10, 2020
Closed
eiffel-fl pushed a commit to eiffel-fl/cli that referenced this pull request Jul 28, 2020
@thaJeztah
vendor: bump hcsshim b3f49c06ffaeef24d09c6c08ec8ec8425a0303e2
50e824c 
full diff: https://2226e083fc390003ae5aa8325c3c92789afa0e7a...b3f49c06ffaeef24d09c6c08ec8ec8425a0303e2

includes:

- microsoft/hcsshim#718 wclayer: Work around Windows bug when expanding sandbox size
    - fixes microsoft/hcsshim#708 Windows Host Compute Service bug breaks docker (and other) sandboxes bigger than 20G on Windows 1903
    - fixes microsoft/hcsshim#624The hcsshim on Windows 10 1903 always fails to build Docker image
    - fixes/addresses docker/for-win#3884 An error occurred while attempting to build Docker image (especially this comment and the next comments after: docker/for-win#3884 (comment))
    - fixes/addresses docker/for-win#4100 Windows 1903 fails when storage-opt used
    - fixes moby/moby#36831 hcsshim::PrepareLayer failed in Win32: The parameter is incorrect (moby/moby#36831 (comment))
    - fixes Stannieman/audacity-with-asio-builder#5 Docker won't build container
    - fixes MicrosoftDocs/visualstudio-docs#3523 Error when running build with storage-opts set
    - fixes moby/moby#39524 Docker build windows 19.03 --storage-opt size>20G

Note that this is a temporary workaround for a bug in the platform, and will be reverted once that is addressed:

- microsoft/hcsshim#721 Revert 718 when Windows 19H1 has expand sandbox fix

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@TBBle TBBle mentioned this pull request Nov 1, 2020
Closed
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
@jterry75
Merge pull request microsoft#718 from jstarks/workaround_expandlayer
9dd97cb 
wclayer: Work around Windows bug when expanding sandbox size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jterry75 jterry75 jterry75 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jstarks @vikramhh @jterry75 @PatrickLang